From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
qemu-arm@nongnu.org, stefanha@redhat.com, crosa@redhat.com,
pbonzini@redhat.com, aurelien@aurel32.net
Subject: Re: [RFC PATCH 3/4] tests/tcg: add sha512 test
Date: Thu, 3 Feb 2022 08:19:01 +1100 [thread overview]
Message-ID: <2b280d2e-cc74-f02d-8b55-1c089cc16d4e@linaro.org> (raw)
In-Reply-To: <20220202191242.652607-4-alex.bennee@linaro.org>
On 2/3/22 06:12, Alex Bennée wrote:
> This imports the sha512 algorithm and related tests from ccan which
> offers a cleaner hash implementation with its own validation tests
> with which we can exercise TCG code generations.
>
> [AJB: this exercise in copy and paste does raise the question of
> should we add ccan as a module to use for writing TCG tests?]
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
> tests/tcg/multiarch/sha512.c | 990 +++++++++++++++++++++++++++++++++++
> 1 file changed, 990 insertions(+)
> create mode 100644 tests/tcg/multiarch/sha512.c
I glanced through and didn't see anything odd.
Could be a decent enough test.
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-02-02 21:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 19:12 [RFC PATCH 0/4] improve coverage of vector backend Alex Bennée
2022-02-02 19:12 ` [RFC PATCH 1/4] tests/tcg: cleanup sha1 source code Alex Bennée
2022-02-02 21:05 ` Richard Henderson
2022-02-02 19:12 ` [RFC PATCH 2/4] tests/tcg: build sha1-vector for SVE and compare Alex Bennée
2022-02-02 21:09 ` Richard Henderson
2022-02-02 19:12 ` [RFC PATCH 3/4] tests/tcg: add sha512 test Alex Bennée
2022-02-02 21:19 ` Richard Henderson [this message]
2022-02-02 19:12 ` [RFC PATCH 4/4] tests/tcg: add vectorised sha512 versions Alex Bennée
2022-02-02 21:18 ` Richard Henderson
2022-02-02 23:16 ` [RFC PATCH 0/4] improve coverage of vector backend Alex Bennée
2022-02-03 1:45 ` Taylor Simpson
2022-02-03 16:33 ` Taylor Simpson
2022-02-03 17:50 ` Alex Bennée
2022-02-03 17:57 ` Taylor Simpson
2022-02-03 18:26 ` Alex Bennée
2022-02-03 19:01 ` Taylor Simpson
2022-02-03 20:00 ` Alex Bennée
2022-02-03 21:05 ` Taylor Simpson
2022-02-03 21:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b280d2e-cc74-f02d-8b55-1c089cc16d4e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).