qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 08/18] kvm: x86: Fix xcr0 reset mismerge
Date: Fri, 21 Jan 2011 21:48:12 +0100	[thread overview]
Message-ID: <2b39929e28d1aba768ec2285bf0d88eaaa7d06ea.1295642900.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1295642900.git.jan.kiszka@web.de>
In-Reply-To: <cover.1295642900.git.jan.kiszka@web.de>

From: Jan Kiszka <jan.kiszka@siemens.com>

For unknown reasons, xcr0 reset ended up in kvm_arch_update_guest_debug
on upstream merge. Fix this and also remove the misleading comment (1 is
THE reset value).

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 target-i386/kvm.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 07c75c0..c4a22dd 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -450,6 +450,7 @@ void kvm_arch_reset_vcpu(CPUState *env)
     env->interrupt_injected = -1;
     env->nmi_injected = 0;
     env->nmi_pending = 0;
+    env->xcr0 = 1;
     if (kvm_irqchip_in_kernel()) {
         env->mp_state = cpu_is_bsp(env) ? KVM_MP_STATE_RUNNABLE :
                                           KVM_MP_STATE_UNINITIALIZED;
@@ -1759,8 +1760,6 @@ void kvm_arch_update_guest_debug(CPUState *env, struct kvm_guest_debug *dbg)
                 ((uint32_t)len_code[hw_breakpoint[n].len] << (18 + n*4));
         }
     }
-    /* Legal xcr0 for loading */
-    env->xcr0 = 1;
 }
 #endif /* KVM_CAP_SET_GUEST_DEBUG */
 
-- 
1.7.1

  parent reply	other threads:[~2011-01-21 20:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 20:48 [Qemu-devel] [PATCH 00/18] [uq/master] Rebased patch queue, part I Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 01/18] kvm: x86: Swallow KVM_EXIT_SET_TPR Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 02/18] kvm: Stop on all fatal exit reasons Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 03/18] kvm: Improve reporting of fatal errors Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 04/18] x86: Optionally dump code bytes on cpu_dump_state Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 05/18] kvm: x86: Align kvm_arch_put_registers code with comment Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 06/18] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 07/18] kvm: x86: Remove redundant mp_state initialization Jan Kiszka
2011-01-21 20:48 ` Jan Kiszka [this message]
2011-01-21 20:48 ` [Qemu-devel] [PATCH 09/18] kvm: x86: Refactor msr_star/hsave_pa setup and checks Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 10/18] kvm: x86: Reset paravirtual MSRs Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 11/18] kvm: x86: Fix !CONFIG_KVM_PARA build Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 12/18] kvm: Drop smp_cpus argument from init functions Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 13/18] kvm: Consolidate must-have capability checks Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 14/18] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 15/18] kvm: Flush coalesced mmio buffer on IO window exits Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 16/18] kvm: Do not use qemu_fair_mutex Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 17/18] kvm: x86: Implicitly clear nmi_injected/pending on reset Jan Kiszka
2011-01-21 20:48 ` [Qemu-devel] [PATCH 18/18] kvm: x86: Only read/write MSR_KVM_ASYNC_PF_EN if supported Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b39929e28d1aba768ec2285bf0d88eaaa7d06ea.1295642900.git.jan.kiszka@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).