From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Weil <sw@weilnetz.de>, Mike Frysinger <vapier@gentoo.org>,
QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools
Date: Tue, 15 May 2018 10:52:09 -0500 [thread overview]
Message-ID: <2b3bb349-8a18-845b-15da-467adcf33bbd@redhat.com> (raw)
In-Reply-To: <CAFEAcA_bbq_ckoUnYs1VvL+389R9KL6HOxxRD2oFMfE05rsg_w@mail.gmail.com>
On 05/15/2018 10:04 AM, Peter Maydell wrote:
>> I'd much prefer this to be:
>>
>> if $strings -a $TMPO | grep...
>>
>> That's because if I have something like this in my environment:
>>
>> STRINGS='/path/to/strings -a'
>>
>> it will only work if you allow word splitting on my variable.
>
> Conversely, if I have STRINGS='/path with spaces/to/strings'
> in my environment it will only work if you don't do word
> splitting on it :-)
Make convention has long been that /path with spaces/ is unacceptable
for any of the typical tool replacements, and that you always perform
unquoted (and thus word splitting) of a tool name. My most common
example is EDITOR='emacs -nw'. You can always add a symlink to a tool
from a path without spaces, if you want to provide a tool override to
something that normally lives somewhere with spaces.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-05-15 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 8:50 [Qemu-devel] [PATCH] configure: Use strings command from cross development tools Stefan Weil
2018-05-13 21:12 ` Philippe Mathieu-Daudé
2018-05-14 15:26 ` Richard Henderson
2018-05-15 15:00 ` Eric Blake
2018-05-15 15:04 ` Peter Maydell
2018-05-15 15:52 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3bb349-8a18-845b-15da-467adcf33bbd@redhat.com \
--to=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).