From: Luc Michel <luc.michel@greensocs.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v5 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
Date: Fri, 11 Sep 2020 21:57:01 +0200 [thread overview]
Message-ID: <2b47f80b-0c4a-5715-af55-19c93c31e30a@greensocs.com> (raw)
In-Reply-To: <20200910205429.727766-5-f4bug@amsat.org>
On 9/10/20 10:54 PM, Philippe Mathieu-Daudé wrote:
> The Witherspoon has 3 LEDs connected to a PCA9552. Add them.
> The names and reset values are taken from:
> https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml
>
> Example booting obmc-phosphor-image:
>
> $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity
> 1592693373.997015:led_change_intensity LED desc:'front-fault-4' color:green intensity 0% -> 100%
> 1592693373.997632:led_change_intensity LED desc:'front-power-3' color:green intensity 0% -> 100%
> 1592693373.998239:led_change_intensity LED desc:'front-id-5' color:green intensity 0% -> 100%
> 1592693500.291805:led_change_intensity LED desc:'front-power-3' color:green intensity 100% -> 0%
> 1592693500.312041:led_change_intensity LED desc:'front-power-3' color:green intensity 0% -> 100%
> 1592693500.821254:led_change_intensity LED desc:'front-power-3' color:green intensity 100% -> 0%
> 1592693501.331517:led_change_intensity LED desc:'front-power-3' color:green intensity 0% -> 100%
> 1592693501.841367:led_change_intensity LED desc:'front-power-3' color:green intensity 100% -> 0%
> 1592693502.350839:led_change_intensity LED desc:'front-power-3' color:green intensity 0% -> 100%
> 1592693502.861134:led_change_intensity LED desc:'front-power-3' color:green intensity 100% -> 0%
> 1592693503.371090:led_change_intensity LED desc:'front-power-3' color:green intensity 0% -> 100%
>
> We notice the front-power LED starts to blink at a ~2Hz rate.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
> ---
> hw/arm/aspeed.c | 20 ++++++++++++++++++++
> hw/arm/Kconfig | 1 +
> 2 files changed, 21 insertions(+)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 8bfb1c79ddc..83e322ea983 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -20,6 +20,7 @@
> #include "hw/i2c/smbus_eeprom.h"
> #include "hw/misc/pca9552.h"
> #include "hw/misc/tmp105.h"
> +#include "hw/misc/led.h"
> #include "hw/qdev-properties.h"
> #include "qemu/log.h"
> #include "sysemu/block-backend.h"
> @@ -521,9 +522,20 @@ static void sonorapass_bmc_i2c_init(AspeedMachineState *bmc)
>
> static void witherspoon_bmc_i2c_init(AspeedMachineState *bmc)
> {
> + static const struct {
> + unsigned gpio_id;
> + LEDColor color;
> + const char *description;
> + bool gpio_polarity;
> + } pca1_leds[] = {
> + {13, LED_COLOR_GREEN, "front-fault-4", GPIO_POLARITY_ACTIVE_LOW},
> + {14, LED_COLOR_GREEN, "front-power-3", GPIO_POLARITY_ACTIVE_LOW},
> + {15, LED_COLOR_GREEN, "front-id-5", GPIO_POLARITY_ACTIVE_LOW},
> + };
> AspeedSoCState *soc = &bmc->soc;
> uint8_t *eeprom_buf = g_malloc0(8 * 1024);
> DeviceState *dev;
> + LEDState *led;
>
> /* Bus 3: TODO bmp280@77 */
> /* Bus 3: TODO max31785@52 */
> @@ -534,6 +546,14 @@ static void witherspoon_bmc_i2c_init(AspeedMachineState *bmc)
> aspeed_i2c_get_bus(&soc->i2c, 3),
> &error_fatal);
>
> + for (size_t i = 0; i < ARRAY_SIZE(pca1_leds); i++) {
> + led = led_create_simple(OBJECT(bmc),
> + pca1_leds[i].gpio_polarity,
> + pca1_leds[i].color,
> + pca1_leds[i].description);
> + qdev_connect_gpio_out(dev, pca1_leds[i].gpio_id,
> + qdev_get_gpio_in(DEVICE(led), 0));
> + }
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 4), "tmp423", 0x4c);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 5), "tmp423", 0x4c);
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index bc3a423940b..06ba1c355b1 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -394,6 +394,7 @@ config ASPEED_SOC
> select TMP105
> select TMP421
> select UNIMP
> + select LED
>
> config MPS2
> bool
>
next prev parent reply other threads:[~2020-09-11 20:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 20:54 [PATCH v5 0/7] hw/misc: Add LED device Philippe Mathieu-Daudé
2020-09-10 20:54 ` [PATCH v5 1/7] hw/misc/led: Add a " Philippe Mathieu-Daudé
2020-09-11 19:42 ` Luc Michel
2020-09-11 22:37 ` Richard Henderson
2020-09-10 20:54 ` [PATCH v5 2/7] hw/misc/led: Allow connecting from GPIO output Philippe Mathieu-Daudé
2020-09-11 19:42 ` Luc Michel
2020-09-12 9:02 ` Philippe Mathieu-Daudé
2020-09-12 9:14 ` Philippe Mathieu-Daudé
2020-09-11 22:44 ` Richard Henderson
2020-09-12 8:50 ` Philippe Mathieu-Daudé
2020-09-12 13:32 ` Philippe Mathieu-Daudé
2020-09-14 7:27 ` Markus Armbruster
2020-09-14 7:48 ` Philippe Mathieu-Daudé
2020-09-14 14:03 ` Eduardo Habkost
2020-09-14 15:05 ` Philippe Mathieu-Daudé
2020-09-14 15:56 ` Philippe Mathieu-Daudé
2020-09-10 20:54 ` [PATCH v5 3/7] hw/misc/led: Emit a trace event when LED intensity has changed Philippe Mathieu-Daudé
2020-09-11 19:43 ` Luc Michel
2020-09-10 20:54 ` [PATCH v5 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1 Philippe Mathieu-Daudé
2020-09-11 19:57 ` Luc Michel [this message]
2020-09-10 20:54 ` [PATCH v5 5/7] hw/misc/mps2-fpgaio: Use the LED device Philippe Mathieu-Daudé
2020-09-11 20:12 ` Luc Michel
2020-09-12 8:06 ` Philippe Mathieu-Daudé
2020-09-11 22:46 ` Richard Henderson
2020-09-10 20:54 ` [PATCH v5 6/7] hw/misc/mps2-scc: " Philippe Mathieu-Daudé
2020-09-11 20:15 ` Luc Michel
2020-09-11 22:47 ` Richard Henderson
2020-09-10 20:54 ` [PATCH v5 7/7] hw/arm/tosa: Replace fprintf() calls by LED devices Philippe Mathieu-Daudé
2020-09-11 19:55 ` Luc Michel
2020-09-11 22:48 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b47f80b-0c4a-5715-af55-19c93c31e30a@greensocs.com \
--to=luc.michel@greensocs.com \
--cc=andrew@aj.id.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).