From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 443D5C5B552 for ; Tue, 10 Jun 2025 07:34:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uOtVC-0000zi-S0; Tue, 10 Jun 2025 03:34:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOtV9-0000zJ-Bq for qemu-devel@nongnu.org; Tue, 10 Jun 2025 03:34:31 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uOtV7-0003G6-1t for qemu-devel@nongnu.org; Tue, 10 Jun 2025 03:34:30 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3a53ee6fcd5so1504245f8f.1 for ; Tue, 10 Jun 2025 00:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749540867; x=1750145667; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kAe2KhF1gPzIHfnQv0JLbg+NNMmazzLcusGORwmMghc=; b=hxb9XemjMc6vgndFM+UoINkSd+xH34HvQmjtpluHgzCOcHY6dq6Glocm30QScRSMyX idi9A/ct3rYesIKr/qaDZbahglJKk0QKrx3gvV/qXWkh7M64BlQoJFBdrji1AhVu9Yq3 sFoAVt0uGtuhTytwZ1kyo4OnUDeP9EMvVQj6rpdCe/iWUBEVJ3+jb/UWGm4E0Ke8vEbw Cn/2r3JvqczRK3j0ddKdnYOMgKouJQokwoQ/skJ2W1qnaU5D+Z9N3ezvPD7suOYkG+YE MoJbM0Wgb3nSOwqQJAqGBLP2WMdlDOFslljLdaDVM0FVcnOLkkIOYm19Z+ek7DnJPG1e W6jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749540867; x=1750145667; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kAe2KhF1gPzIHfnQv0JLbg+NNMmazzLcusGORwmMghc=; b=wO50VDjw8JdKUkE+R0PnaSbw7YnKvOH47GvuogyWUeD1KAr4a9xhpRsbJBdxLUA+5p cTsLkUjQXE7Cwr1mRLbN6SO9aGKlxqAKys1UyovSICHm6TgTYWgQWZR4rMzQSwRF83pd SoJSYtO3TIYuk/jEQVYwKs5yu4bX/b+0TiMJVbqoIWNXh6DmY4o+GrIn2lFDR2XjgU1h tWKxLihzdTv0iSrwrHlWCWF4iKWngmppvOJMmBmG3IvkFpjzWoiX9FoTF5WftQrWEIrX 6wrL/6Y15JoDUV84smy0lfNrvZpemWRx71eelJkrQPfitAcqsFHRTzGXn0n3adnrweN/ oEiQ== X-Forwarded-Encrypted: i=1; AJvYcCUyY1PIcpo1r+vsayTlQ4zKcqdvPlzg19tKTAv7Ag7repOl2/XSzCwfjAAzyZoKQsA1nNa7VbgEO+xa@nongnu.org X-Gm-Message-State: AOJu0YwiTJ2qs4p0n6NYZT8erAn2hDU9dxBWlH+iwEgDsN6R6/6iXTnz VL9hPbWgqghL3nnSnCHmnlW0jWkfo5aG3hFqx9vdsgi8UrRZ7T7sbOhh71xwbux9SoU= X-Gm-Gg: ASbGncvQeoQksScTPckFM8v3Nj2epAju5Q6v4/WrZHvPvde3256efiVdepRW7vEEiKa FecHnBnUtFtByyDq5/SpatZyu4IsR77AlbUcUapvLQuD+OUTFqSplc58kyt9bDNiOdfakFoi8Mt Iko9M+vWe6DbJ7qPrTqcJWFcfyXhzHJ+Kz4I5QzjelCuJAubcfnqFmNni2QMTJGYJ0dBosJzSv9 UypgGl6Ps8QXpng7HRn6LvvNk6wNhpa4Ozp1Mv1yAPwgGrluFg9VNl/MfmEpwSfMrPib6uUqG8L SETF8vbmPSNvBEfT5nk3Q40/AQy//iVYcqq+Vnqp9nTBczH1uacChJ3K+MLnqaAQz8oE47UjdDc AclQZN+epUx0woyG0VCokXCn14gmIqbye36Y= X-Google-Smtp-Source: AGHT+IFN0Wn1IiTW8yMmOmxQlK5i0E8SRsAl+K77couTWwuqCqkky0mkxw0Oj+ZrApVf4KIADtsAjQ== X-Received: by 2002:a05:6000:40dc:b0:3a4:e5bc:9892 with SMTP id ffacd0b85a97d-3a531cac62bmr12634916f8f.21.1749540866729; Tue, 10 Jun 2025 00:34:26 -0700 (PDT) Received: from [192.168.69.138] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5324638e9sm11338840f8f.89.2025.06.10.00.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 00:34:26 -0700 (PDT) Message-ID: <2b5cd757-5440-43d5-9415-6f2ccb5f2ea6@linaro.org> Date: Tue, 10 Jun 2025 09:34:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] hw/intc: Allow gaps in hartids for aclint and aplic To: Djordje Todorovic , "qemu-devel@nongnu.org" Cc: "qemu-riscv@nongnu.org" , "cfu@mips.com" References: <20250602131226.1137281-1-djordje.todorovic@htecgroup.com> <20250602131226.1137281-2-djordje.todorovic@htecgroup.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250602131226.1137281-2-djordje.todorovic@htecgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On 2/6/25 15:12, Djordje Todorovic wrote: > This is needed for riscv based CPUs by MIPS. This justification is not really convincing. > > Signed-off-by: Chao-ying Fu > Signed-off-by: Djordje Todorovic > --- > hw/intc/riscv_aclint.c | 33 +++++++++++++++++++++++++++++++-- > hw/intc/riscv_aplic.c | 10 +++++++--- > 2 files changed, 38 insertions(+), 5 deletions(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index b0139f03f5..5bda02a179 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -131,6 +131,9 @@ static uint64_t riscv_aclint_mtimer_read(void *opaque, hwaddr addr, > size_t hartid = mtimer->hartid_base + > ((addr - mtimer->timecmp_base) >> 3); > CPUState *cpu = cpu_by_arch_id(hartid); > + if (cpu == NULL) { > + return 0; It looks like some misconfiguration. How do you reach that? Otherwise please log as GUEST_ERROR. > + } > CPURISCVState *env = cpu ? cpu_env(cpu) : NULL; > if (!env) { > qemu_log_mask(LOG_GUEST_ERROR, > @@ -174,6 +177,9 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, > size_t hartid = mtimer->hartid_base + > ((addr - mtimer->timecmp_base) >> 3); > CPUState *cpu = cpu_by_arch_id(hartid); > + if (cpu == NULL) { If so, please log: qemu_log_mask(LOG_GUEST_ERROR, "aclint-mtimer: invalid hartid: %zu", hartid); > + return; > + } > CPURISCVState *env = cpu ? cpu_env(cpu) : NULL; Then env is valid, so this line needs update.