Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter

[Paolo Bonzini <pbonzini@redhat.com>]

On 25/01/21 15:45, Philippe Mathieu-Daudé wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
> 
> The configure option was backward, and we failed to
> pass the value on to meson.
> 
> Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Message-Id: <20210124211119.35563-1-richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   configure | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index dcc5ea7d630..526c4cc1306 100755
> --- a/configure
> +++ b/configure
> @@ -1119,9 +1119,9 @@ for opt do
>     ;;
>     --enable-whpx) whpx="enabled"
>     ;;
> -  --disable-tcg-interpreter) tcg_interpreter="true"
> +  --disable-tcg-interpreter) tcg_interpreter="false"
>     ;;
> -  --enable-tcg-interpreter) tcg_interpreter="false"
> +  --enable-tcg-interpreter) tcg_interpreter="true"
>     ;;
>     --disable-cap-ng)  cap_ng="disabled"
>     ;;
> @@ -6361,6 +6361,7 @@ NINJA=$ninja $meson setup \
>           -Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \
>           -Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \
>           -Dxen=$xen -Dxen_pci_passthrough=$xen_pci_passthrough -Dtcg=$tcg \
> +        -Dtcg_interpreter=$tcg_interpreter \
>           -Dcocoa=$cocoa -Dgtk=$gtk -Dmpath=$mpath -Dsdl=$sdl -Dsdl_image=$sdl_image \
>           -Dvnc=$vnc -Dvnc_sasl=$vnc_sasl -Dvnc_jpeg=$vnc_jpeg -Dvnc_png=$vnc_png \
>           -Dgettext=$gettext -Dxkbcommon=$xkbcommon -Du2f=$u2f -Dvirtiofsd=$virtiofsd \
> 

Too bad, sorry.

There were two things to do when rebasing before the "automatic command 
line parsing" patch, and I messed up both of them.

Paolo