qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Bernhard Beschow <shentey@gmail.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	vr_qemu@t-online.de
Subject: Re: [PATCH v3 0/4] Fix IRQ routing in via south bridge
Date: Tue, 28 Nov 2023 14:26:06 +0100	[thread overview]
Message-ID: <2b8e0424-1b93-4ae1-9d66-aeeaf7afc313@linaro.org> (raw)
In-Reply-To: <cc64f407-9a5a-d0b7-33b7-0f142a9ec6a1@eik.bme.hu>

Hi Zoltan,

On 28/11/23 13:47, BALATON Zoltan wrote:
> On Sun, 26 Nov 2023, BALATON Zoltan wrote:
>> Philippe,
>>
>> Could this be merged for 8.2 as it fixes USB on the amigaone machine?
>> This would be useful as usb-storage is the simplest way to share data
>> with the host with these machines.
> 
> Philippe, do you have some time to look at this now for 8.2 please? I 
> still hope this could be fixed for the amigaone machine on release and 
> dont' have to wait until the next one for USB to work on that machine.

Thanks for your detailed cover and patch descriptions.

I just finished to run my tests and they all passed.

I couldn't spend much time reviewing the patches, but having a quick
look I don't think the way you model it is correct. This is a tricky
setup and apparently we don't fully understand it (I understand what
you explained, but some pieces don't make sense to me). That said,
I understand it help you and the AmigaOne users, and nobody objected.
So, while being a bit reluctant, I am queuing this series; and will
send a PR in a few. We'll have time to improve this model later.

Regards,

Phil.



  reply	other threads:[~2023-11-28 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-26 22:49 [PATCH v3 0/4] Fix IRQ routing in via south bridge BALATON Zoltan
2023-11-26 22:49 ` [PATCH v3 1/4] hw/isa/vt82c686: Bring back via_isa_set_irq() BALATON Zoltan
2023-11-26 22:49 ` [PATCH v3 2/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts BALATON Zoltan
2023-11-26 22:49 ` [PATCH v3 3/4] hw/isa/vt82c686: Route PIRQ inputs using via_isa_set_irq() BALATON Zoltan
2023-11-26 22:49 ` [PATCH v3 4/4] hw/audio/via-ac97: Route interrupts " BALATON Zoltan
2023-11-28 12:47 ` [PATCH v3 0/4] Fix IRQ routing in via south bridge BALATON Zoltan
2023-11-28 13:26   ` Philippe Mathieu-Daudé [this message]
2023-11-28 14:18     ` BALATON Zoltan
2023-11-29 12:13 ` Michael Tokarev
2023-11-29 12:40   ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b8e0424-1b93-4ae1-9d66-aeeaf7afc313@linaro.org \
    --to=philmd@linaro.org \
    --cc=balaton@eik.bme.hu \
    --cc=jiaxun.yang@flygoat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=shentey@gmail.com \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).