From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs0qn-0004LY-BB for qemu-devel@nongnu.org; Fri, 08 Feb 2019 02:45:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs0qk-0008Ay-TM for qemu-devel@nongnu.org; Fri, 08 Feb 2019 02:45:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40602) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gs0qd-00084p-Sy for qemu-devel@nongnu.org; Fri, 08 Feb 2019 02:45:24 -0500 References: <87d0o24u0s.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: <2b9153c1-2a2d-f55a-3c00-121752bf3036@redhat.com> Date: Fri, 8 Feb 2019 08:45:05 +0100 MIME-Version: 1.0 In-Reply-To: <87d0o24u0s.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Maintainers, please git-am -m List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Kevin Wolf , "Michael S. Tsirkin" , Palmer Dabbelt , Richard Henderson , Max Filippov , Aleksandar Markovic , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Anthony PERARD , Samuel Thibault , =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson On 2019-02-08 08:30, Markus Armbruster wrote: > Short story: please add >=20 > [am] > messageid =3D true >=20 > to your .gitconfig. >=20 > Long story. git-am can add a Message-id: tag. Looks like this: >=20 > commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c > Author: Thomas Huth > Date: Mon Feb 4 09:25:43 2019 +0100 > Commit: Peter Maydell > CommitDate: Mon Feb 4 15:25:21 2019 +0000 >=20 > tests/docker/test-mingw and docs: Remove --with-sdlabi=3D2.0 >=20 > Patchew currently reports failures with the mingw docker test -= this > is due to --with-sdlabi=3D2.0 configure flag which does not exi= st anymore. > Remove this remainder from the docker test and the docs now. >=20 > Signed-off-by: Thomas Huth > Reviewed-by: Daniel P. Berrang=C3=A9 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 > Acked-by: Alex Benn=C3=A9e > ---> Message-id: 1549268743-18502-1-git-send-email-thuth@redhat.com > Signed-off-by: Peter Maydell >=20 > The Message-id identifies the patch e-mail. It makes finding the revie= w > thread easier and more reliable. It's also a valid key on Patchew[*]. >=20 > Sadly, not all of our commits don't carry it. Here's how top committer= s > have been doing recently[**]: >=20 > with without > 264 21 Peter Maydell > 65 2 Gerd Hoffmann > 64 0 Laurent Vivier > 64 0 Eric Blake > 62 1 Eduardo Habkost > 56 0 Markus Armbruster > 29 72 Richard Henderson > 24 24 Paolo Bonzini > 10 31 Marcel Apfelbaum > 0 107 Kevin Wolf > 0 106 David Gibson > 0 93 Michael S. Tsirkin > 0 81 Aleksandar Markovic > 0 69 Samuel Thibault > 0 54 Alex Benn=C3=A9e > 0 50 Thomas Huth > 0 29 Anthony PERARD > 0 28 Marc-Andr=C3=A9 Lureau >=20 > Not bad, but there's room for improvement. I'd like to, but I can't. I'm still using git 1.8 and the -m parameter is not supported there yet. Thomas