From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Alexander Bulekov <alxndr@bu.edu>,
qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)
Date: Tue, 26 May 2020 09:23:13 +0200 [thread overview]
Message-ID: <2b9ed3fc-2f57-7202-0c15-52de18fc890c@redhat.com> (raw)
In-Reply-To: <20200524103833.8188-1-f4bug@amsat.org>
On 24/05/2020 12.38, Philippe Mathieu-Daudé wrote:
> Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is
> disabled by default. This avoid flooding the terminal when
> fuzzing the device.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/display/omap_dss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/omap_dss.c b/hw/display/omap_dss.c
> index 32dc0d6aa7..21fde58a26 100644
> --- a/hw/display/omap_dss.c
> +++ b/hw/display/omap_dss.c
> @@ -619,7 +619,7 @@ static void omap_rfbi_transfer_start(struct omap_dss_s *s)
> if (s->rfbi.control & (1 << 1)) { /* BYPASS */
> /* TODO: in non-Bypass mode we probably need to just assert the
> * DRQ and wait for DMA to write the pixels. */
> - fprintf(stderr, "%s: Bypass mode unimplemented\n", __func__);
> + qemu_log_mask(LOG_UNIMP, "%s: Bypass mode unimplemented\n", __func__);
> return;
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2020-05-26 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 10:38 [PATCH] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP) Philippe Mathieu-Daudé
2020-05-24 12:41 ` Alexander Bulekov
2020-05-24 13:53 ` Philippe Mathieu-Daudé
2020-05-26 7:23 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b9ed3fc-2f57-7202-0c15-52de18fc890c@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).