From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F008C433E0 for ; Fri, 5 Feb 2021 20:16:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 450FF64FCA for ; Fri, 5 Feb 2021 20:16:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 450FF64FCA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l87Wx-00079B-0u for qemu-devel@archiver.kernel.org; Fri, 05 Feb 2021 15:16:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l87V9-0006AU-Tl for qemu-devel@nongnu.org; Fri, 05 Feb 2021 15:14:47 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:43106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l87V7-0003lM-UP for qemu-devel@nongnu.org; Fri, 05 Feb 2021 15:14:47 -0500 Received: by mail-pl1-x630.google.com with SMTP id 8so4125381plc.10 for ; Fri, 05 Feb 2021 12:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UN8SmGU45KBjyYJCZ4q4aL+iGJBVwSSsluft4VeySdM=; b=kNSnSQEYDLOuG9eT8Ocaq1WKw8AzxOrRPGaVMcAa9RQZuYUsbpVRjUcgupPEwtRZCw LDx2r1ivM2mD32TEJeOrUn9JFMuSUAU68ypJJvpUvFuRoIGMe3/Zp7jRwVsAbcY72Za+ vQOxtnaAcc9Xsl00yzr4Ra8GFElQ1fbDXRpBwvqESc6G7uWNLBqOUeZhXp5gUHB1B+mX NpJmVNxrSNOgKP+jyH4EDz8ahTkD0cFqNk+00yPlGaWpYpE3ArcnbX0ihSKCRoPVkddI lC3krnc1N5R0ao4G9tWZF97yKDqvwKK3oFEM/qGJJAdtWnpMT7sA8wA+zABzcLpKfYZn U/+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UN8SmGU45KBjyYJCZ4q4aL+iGJBVwSSsluft4VeySdM=; b=fO7Q7wnUBAwd4aO2c18knRxGfXhwAAByOtKNMSPcKh1pjM2/wLz1HGeC+3AQP5iTtX b8/n48tAHYSgjTOWxW24uT1nN9lGufv19pMW8blDLeXLBnW9tTSxntjBxgnKwB+VEZIt curQ7vqtpyvSAxWUrXraLzy/k8FGuGNRCIGepczxUKBZuVDl2xsYX+dky+iu9EHpmGVM SKwHwM1QikNpd2EXVFDCKa08BIPpjq0tb0/fFp5gYRB2Sr3Fl24pZ/70rKyzMURmnolO zsjqvhgnp1gnDIhOsB3+5fkaCTTK45Dpco3D6a7qofxsG+1PhuYwmU3ov+rXmj/Vl2Hz 2Oew== X-Gm-Message-State: AOAM5324Y3zSjXEJuw6CxxuwtmfjKmMzq02zpwuqsoju4Z65hd2UVvg7 JI3NfbV102VI9NFwwHxghVu9FQMDJXcBbEOW X-Google-Smtp-Source: ABdhPJycbtEq/07siu0mrcNzSGHCqizY4ip/MsrrlDmOSKh5WmlHlRxXSsDdWpFvIO5jbG1iUGjRVQ== X-Received: by 2002:a17:902:e8cb:b029:e2:9906:45a6 with SMTP id v11-20020a170902e8cbb02900e2990645a6mr5591704plg.41.1612556084267; Fri, 05 Feb 2021 12:14:44 -0800 (PST) Received: from [192.168.3.43] (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id s18sm7936976pfm.129.2021.02.05.12.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 12:14:42 -0800 (PST) Subject: Re: [PATCH v16 21/23] accel: introduce new accessor functions To: Claudio Fontana , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , Peter Maydell References: <20210204163931.7358-1-cfontana@suse.de> <20210204163931.7358-22-cfontana@suse.de> From: Richard Henderson Message-ID: <2bb1cba6-e1a0-80a7-4c05-fb221f4f8230@linaro.org> Date: Fri, 5 Feb 2021 10:14:39 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210204163931.7358-22-cfontana@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.33, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Alistair Francis , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/4/21 6:39 AM, Claudio Fontana wrote: > @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj) > x86_cpu_load_model(cpu, xcc->model); > } > > - /* if required, do the accelerator-specific cpu initialization */ > - if (cc->accel_cpu) { > - cc->accel_cpu->cpu_instance_init(CPU(obj)); > - } > + /* if required, do accelerator-specific cpu initializations */ > + accel_cpu_instance_init(CPU(obj)); > } Why is this only done for x86? r~