* [PATCH] replay: Remove unused replay_disable_events
@ 2024-09-18 23:40 dave
2024-09-19 4:59 ` Pavel Dovgalyuk
2024-10-02 10:41 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: dave @ 2024-09-18 23:40 UTC (permalink / raw)
To: pavel.dovgaluk, pbonzini, qemu-devel; +Cc: Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <dave@treblig.org>
replay_disable_events has been unused since 2019's
c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
include/sysemu/replay.h | 2 --
replay/replay-events.c | 9 ---------
2 files changed, 11 deletions(-)
diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
index 8102fa54f0..cba74fa9bc 100644
--- a/include/sysemu/replay.h
+++ b/include/sysemu/replay.h
@@ -117,8 +117,6 @@ void replay_async_events(void);
/* Asynchronous events queue */
-/*! Disables storing events in the queue */
-void replay_disable_events(void);
/*! Enables storing events in the queue */
void replay_enable_events(void);
/*! Returns true when saving events is enabled */
diff --git a/replay/replay-events.c b/replay/replay-events.c
index af0721cc1a..2e46eda6bf 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -92,15 +92,6 @@ void replay_flush_events(void)
}
}
-void replay_disable_events(void)
-{
- if (replay_mode != REPLAY_MODE_NONE) {
- events_enabled = false;
- /* Flush events queue before waiting of completion */
- replay_flush_events();
- }
-}
-
/*! Adds specified async event to the queue */
void replay_add_event(ReplayAsyncEventKind event_kind,
void *opaque,
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] replay: Remove unused replay_disable_events
2024-09-18 23:40 [PATCH] replay: Remove unused replay_disable_events dave
@ 2024-09-19 4:59 ` Pavel Dovgalyuk
2024-10-02 10:41 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Dovgalyuk @ 2024-09-19 4:59 UTC (permalink / raw)
To: dave, pavel.dovgaluk, pbonzini, qemu-devel
Reviewed-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
On 19.09.2024 02:40, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> replay_disable_events has been unused since 2019's
> c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> include/sysemu/replay.h | 2 --
> replay/replay-events.c | 9 ---------
> 2 files changed, 11 deletions(-)
>
> diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
> index 8102fa54f0..cba74fa9bc 100644
> --- a/include/sysemu/replay.h
> +++ b/include/sysemu/replay.h
> @@ -117,8 +117,6 @@ void replay_async_events(void);
>
> /* Asynchronous events queue */
>
> -/*! Disables storing events in the queue */
> -void replay_disable_events(void);
> /*! Enables storing events in the queue */
> void replay_enable_events(void);
> /*! Returns true when saving events is enabled */
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index af0721cc1a..2e46eda6bf 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -92,15 +92,6 @@ void replay_flush_events(void)
> }
> }
>
> -void replay_disable_events(void)
> -{
> - if (replay_mode != REPLAY_MODE_NONE) {
> - events_enabled = false;
> - /* Flush events queue before waiting of completion */
> - replay_flush_events();
> - }
> -}
> -
> /*! Adds specified async event to the queue */
> void replay_add_event(ReplayAsyncEventKind event_kind,
> void *opaque,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] replay: Remove unused replay_disable_events
2024-09-18 23:40 [PATCH] replay: Remove unused replay_disable_events dave
2024-09-19 4:59 ` Pavel Dovgalyuk
@ 2024-10-02 10:41 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-10-02 10:41 UTC (permalink / raw)
To: dave, pavel.dovgaluk, pbonzini, qemu-devel, QEMU Trivial
On 19/09/2024 01.40, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> replay_disable_events has been unused since 2019's
> c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> include/sysemu/replay.h | 2 --
> replay/replay-events.c | 9 ---------
> 2 files changed, 11 deletions(-)
>
> diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
> index 8102fa54f0..cba74fa9bc 100644
> --- a/include/sysemu/replay.h
> +++ b/include/sysemu/replay.h
> @@ -117,8 +117,6 @@ void replay_async_events(void);
>
> /* Asynchronous events queue */
>
> -/*! Disables storing events in the queue */
> -void replay_disable_events(void);
> /*! Enables storing events in the queue */
> void replay_enable_events(void);
> /*! Returns true when saving events is enabled */
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index af0721cc1a..2e46eda6bf 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -92,15 +92,6 @@ void replay_flush_events(void)
> }
> }
>
> -void replay_disable_events(void)
> -{
> - if (replay_mode != REPLAY_MODE_NONE) {
> - events_enabled = false;
> - /* Flush events queue before waiting of completion */
> - replay_flush_events();
> - }
> -}
> -
> /*! Adds specified async event to the queue */
> void replay_add_event(ReplayAsyncEventKind event_kind,
> void *opaque,
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-02 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 23:40 [PATCH] replay: Remove unused replay_disable_events dave
2024-09-19 4:59 ` Pavel Dovgalyuk
2024-10-02 10:41 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).