From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Vladislav Yaroshchuk <yaroshchuk2000@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org,
jasowang@redhat.com, phillip.ennen@gmail.com, armbru@redhat.com,
dirty@apple.com, f4bug@amsat.org, r.bolshakov@yadro.com,
agraf@csgraf.de, phillip@axleos.com, roman@roolebo.dev,
hsp.cat7@gmail.com, hello@adns.io, qemu_oss@crudebyte.com,
eblake@redhat.com, kraxel@redhat.com
Subject: Re: [PATCH v13 6/7] net/vmnet: update qemu-options.hx
Date: Fri, 14 Jan 2022 17:43:49 +0900 [thread overview]
Message-ID: <2bc90989-fd13-932a-30c7-780cbb691cfe@gmail.com> (raw)
In-Reply-To: <20220113172219.66372-7-yaroshchuk2000@gmail.com>
The corresponding change for hmp-commands.hx is missing (Look for
hmp_netdev_add).
Regards,
Akihiko Odaki
On 2022/01/14 2:22, Vladislav Yaroshchuk wrote:
> Signed-off-by: Vladislav Yaroshchuk <yaroshchuk2000@gmail.com>
> ---
> qemu-options.hx | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ec90505d84..81dd34f550 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2732,6 +2732,25 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
> #ifdef __linux__
> "-netdev vhost-vdpa,id=str,vhostdev=/path/to/dev\n"
> " configure a vhost-vdpa network,Establish a vhost-vdpa netdev\n"
> +#endif
> +#ifdef CONFIG_VMNET
> + "-netdev vmnet-host,id=str[,isolated=on|off][,net-uuid=uuid]\n"
> + " [,start-address=addr,end-address=addr,subnet-mask=mask]\n"
> + " configure a vmnet network backend in host mode with ID 'str',\n"
> + " isolate this interface from others with 'isolated',\n"
> + " configure the address range and choose a subnet mask,\n"
> + " specify network UUID 'uuid' to disable DHCP and interact with\n"
> + " vmnet-host interfaces within this isolated network\n"
> + "-netdev vmnet-shared,id=str[,isolated=on|off][,nat66-prefix=addr]\n"
> + " [,start-address=addr,end-address=addr,subnet-mask=mask]\n"
> + " configure a vmnet network backend in shared mode with ID 'str',\n"
> + " configure the address range and choose a subnet mask,\n"
> + " set IPv6 ULA prefix (of length 64) to use for internal network,\n"
> + " isolate this interface from others with 'isolated'\n"
> + "-netdev vmnet-bridged,id=str,ifname=name[,isolated=on|off]\n"
> + " configure a vmnet network backend in bridged mode with ID 'str',\n"
> + " use 'ifname=name' to select a physical network interface to be bridged,\n"
> + " isolate this interface from others with 'isolated'\n"
> #endif
> "-netdev hubport,id=str,hubid=n[,netdev=nd]\n"
> " configure a hub port on the hub with ID 'n'\n", QEMU_ARCH_ALL)
> @@ -2751,6 +2770,9 @@ DEF("nic", HAS_ARG, QEMU_OPTION_nic,
> #endif
> #ifdef CONFIG_POSIX
> "vhost-user|"
> +#endif
> +#ifdef CONFIG_VMNET
> + "vmnet-host|vmnet-shared|vmnet-bridged|"
> #endif
> "socket][,option][,...][mac=macaddr]\n"
> " initialize an on-board / default host NIC (using MAC address\n"
> @@ -2773,6 +2795,9 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
> #endif
> #ifdef CONFIG_NETMAP
> "netmap|"
> +#endif
> +#ifdef CONFIG_VMNET
> + "vmnet-host|vmnet-shared|vmnet-bridged|"
> #endif
> "socket][,option][,option][,...]\n"
> " old way to initialize a host network interface\n"
next prev parent reply other threads:[~2022-01-14 8:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 17:22 [PATCH v13 0/7] Add vmnet.framework based network backend Vladislav Yaroshchuk
2022-01-13 17:22 ` [PATCH v13 1/7] net/vmnet: add vmnet dependency and customizable option Vladislav Yaroshchuk
2022-01-20 7:14 ` Roman Bolshakov
2022-01-21 11:58 ` Vladislav Yaroshchuk
2022-01-13 17:22 ` [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net Vladislav Yaroshchuk
2022-01-14 8:43 ` Akihiko Odaki
2022-01-15 13:00 ` Vladislav Yaroshchuk
2022-01-18 15:00 ` Markus Armbruster
2022-01-18 16:16 ` Vladislav Yaroshchuk
2022-01-18 16:26 ` Markus Armbruster
2022-01-18 16:46 ` Vladislav Yaroshchuk
2022-01-20 8:32 ` Roman Bolshakov
2022-01-21 12:19 ` Vladislav Yaroshchuk
2022-01-21 13:03 ` Akihiko Odaki
2022-01-28 14:29 ` Vladislav Yaroshchuk
2022-01-28 23:00 ` Akihiko Odaki
2022-01-24 9:56 ` Roman Bolshakov
2022-01-24 11:27 ` Christian Schoenebeck
2022-01-24 17:49 ` Roman Bolshakov
2022-01-24 20:00 ` Christian Schoenebeck
2022-01-24 20:14 ` Peter Maydell
2022-01-24 23:00 ` Roman Bolshakov
2022-01-25 4:14 ` Akihiko Odaki
2022-01-25 10:32 ` Peter Maydell
2022-01-25 11:08 ` Akihiko Odaki
2022-01-25 17:30 ` Christian Schoenebeck
2022-01-29 21:03 ` Roman Bolshakov
2022-01-13 17:22 ` [PATCH v13 3/7] net/vmnet: implement shared mode (vmnet-shared) Vladislav Yaroshchuk
2022-01-14 8:43 ` Akihiko Odaki
2022-01-13 17:22 ` [PATCH v13 4/7] net/vmnet: implement host mode (vmnet-host) Vladislav Yaroshchuk
2022-01-13 17:22 ` [PATCH v13 5/7] net/vmnet: implement bridged mode (vmnet-bridged) Vladislav Yaroshchuk
2022-01-14 8:43 ` Akihiko Odaki
2022-01-13 17:22 ` [PATCH v13 6/7] net/vmnet: update qemu-options.hx Vladislav Yaroshchuk
2022-01-14 8:43 ` Akihiko Odaki [this message]
2022-01-13 17:22 ` [PATCH v13 7/7] net/vmnet: update MAINTAINERS list Vladislav Yaroshchuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc90989-fd13-932a-30c7-780cbb691cfe@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=dirty@apple.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=hello@adns.io \
--cc=hsp.cat7@gmail.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phillip.ennen@gmail.com \
--cc=phillip@axleos.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=r.bolshakov@yadro.com \
--cc=roman@roolebo.dev \
--cc=yaroshchuk2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).