qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Joao Martins <joao.m.martins@oracle.com>,
	Avihai Horon <avihaih@nvidia.com>,
	qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
	Cedric Le Goater <clg@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3 2/2] hw/vfio: Add nr of dirty pages to vfio_get_dirty_bitmap tracepoint
Date: Tue, 30 May 2023 12:01:58 +0200	[thread overview]
Message-ID: <2bcc75a8-89ee-2ff5-9d9d-fc48ec6fc27d@linaro.org> (raw)
In-Reply-To: <2aa582b9-2b37-e96c-1dc4-4c0dbcaebf23@oracle.com>

On 30/5/23 10:48, Joao Martins wrote:
> 
> 
> On 30/05/2023 09:39, Avihai Horon wrote:
>>
>> On 29/05/2023 15:11, Joao Martins wrote:
>>> External email: Use caution opening links or attachments
>>>
>> Just a nit, maybe subject should be "vfio/common: Add number of dirty pages to
>> vfio_get_dirty_bitmap tracepoint".
>>
> 
> Fixed
> 
>>> Include the number of dirty pages on the vfio_get_dirty_bitmap tracepoint.
>>> These are fetched from the newly added return value in
>>> cpu_physical_memory_set_lebitmap().
>>
>> s/cpu_physical_memory_set_lebitmap()/cpu_physical_memory_set_dirty_lebitmap()
>>
> Fixed

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



      reply	other threads:[~2023-05-30 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 12:11 [PATCH v3 0/2] hw/vfio: Improve vfio_get_dirty_bitmap() tracepoint Joao Martins
2023-05-29 12:11 ` [PATCH v3 1/2] exec/ram_addr: return nr of dirty pages in cpu_physical_memory_set_dirty_lebitmap() Joao Martins
2023-05-30  8:37   ` Avihai Horon
2023-05-30  8:48     ` Joao Martins
2023-05-30 12:44   ` Philippe Mathieu-Daudé
2023-05-29 12:11 ` [PATCH v3 2/2] hw/vfio: Add nr of dirty pages to vfio_get_dirty_bitmap tracepoint Joao Martins
2023-05-30  8:17   ` Cédric Le Goater
2023-05-30  8:39   ` Avihai Horon
2023-05-30  8:48     ` Joao Martins
2023-05-30 10:01       ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bcc75a8-89ee-2ff5-9d9d-fc48ec6fc27d@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=clg@redhat.com \
    --cc=david@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).