[PATCH] tests/acceptance/virtio_check_params: Disable test

[PATCH] tests/acceptance/virtio_check_params: Disable test

[Philippe Mathieu-Daudé]

This test fails on various CI:

- Using QEMU 4.0:

  tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias:  ERROR: 'alias-of' (0.45 s)

- On OSX

   Unexpected error in object_property_find() at qom/object.c:1201:
   qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found

- When removing unavailable machine:

  VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x not in list (0.12 s)

- Using Xen:

  xencall: error: Could not obtain handle on privileged command interface: No such file or directory
  xen be core: xen be core: can't open xen interface

- On PPC:

  TestFail: machine type pseries-2.8: No Transactional Memory support in TCG, try appending -machine cap-htm=off

- On S390X:

  ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 'virtio-scsi-pci' is not a valid device model name

Disable it for now.

Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Series fixing the errors:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
---
 tests/acceptance/virtio_check_params.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py
index d5f345f75e..87e6c839d1 100644
--- a/tests/acceptance/virtio_check_params.py
+++ b/tests/acceptance/virtio_check_params.py
@@ -25,6 +25,7 @@ import logging
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
 from qemu.machine import QEMUMachine
 from avocado_qemu import Test
+from avocado import skip
 
 #list of machine types and virtqueue properties to test
 VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'}
@@ -116,6 +117,7 @@ class VirtioMaxSegSettingsCheck(Test):
             return True
         return False
 
+    @skip("break multi-arch CI")
     def test_machine_types(self):
         # collect all machine types except 'none', 'isapc', 'microvm'
         with QEMUMachine(self.qemu_bin) as vm:
-- 
2.21.1

Re: [PATCH] tests/acceptance/virtio_check_params: Disable test

[Cornelia Huck]

On Thu,  6 Feb 2020 18:17:15 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> This test fails on various CI:
> 
> - Using QEMU 4.0:
> 
>   tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias:  ERROR: 'alias-of' (0.45 s)
> 
> - On OSX
> 
>    Unexpected error in object_property_find() at qom/object.c:1201:
>    qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found

Hm, but there was a fix for that, wasn't there?

> 
> - When removing unavailable machine:
> 
>   VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x not in list (0.12 s)
> 
> - Using Xen:
> 
>   xencall: error: Could not obtain handle on privileged command interface: No such file or directory
>   xen be core: xen be core: can't open xen interface
> 
> - On PPC:
> 
>   TestFail: machine type pseries-2.8: No Transactional Memory support in TCG, try appending -machine cap-htm=off
> 
> - On S390X:
> 
>   ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 'virtio-scsi-pci' is not a valid device model name

Depends on how your QEMU is configured... does virtio-pci default to
off on s390x? I use it all the time to test pci :)

> 
> Disable it for now.
> 
> Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Series fixing the errors:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
> ---
>  tests/acceptance/virtio_check_params.py | 2 ++
>  1 file changed, 2 insertions(+)
> 

It seems reasonable though to disable it until the problems are fixed.

Acked-by: Cornelia Huck <cohuck@redhat.com>

Re: [PATCH] tests/acceptance/virtio_check_params: Disable test

[Philippe Mathieu-Daudé]

On 2/6/20 6:24 PM, Cornelia Huck wrote:
> On Thu,  6 Feb 2020 18:17:15 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
>> This test fails on various CI:
>>
>> - Using QEMU 4.0:
>>
>>    tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias:  ERROR: 'alias-of' (0.45 s)
>>
>> - On OSX
>>
>>     Unexpected error in object_property_find() at qom/object.c:1201:
>>     qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found
> 
> Hm, but there was a fix for that, wasn't there?

Yes, the patch is on the list:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675259.html

Michael S. Tsirkin takes virtio, I'll ping him to see if he wants a 
respin or can take it and amend your suggestions.

>>
>> - When removing unavailable machine:
>>
>>    VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x not in list (0.12 s)
>>
>> - Using Xen:
>>
>>    xencall: error: Could not obtain handle on privileged command interface: No such file or directory
>>    xen be core: xen be core: can't open xen interface
>>
>> - On PPC:
>>
>>    TestFail: machine type pseries-2.8: No Transactional Memory support in TCG, try appending -machine cap-htm=off
>>
>> - On S390X:
>>
>>    ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 'virtio-scsi-pci' is not a valid device model name
> 
> Depends on how your QEMU is configured... does virtio-pci default to
> off on s390x? I use it all the time to test pci :)

Yes, this is a --without-default-devices job indeed.

>>
>> Disable it for now.
>>
>> Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Series fixing the errors:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
>> ---
>>   tests/acceptance/virtio_check_params.py | 2 ++
>>   1 file changed, 2 insertions(+)
>>
> 
> It seems reasonable though to disable it until the problems are fixed.

The patches are on the list, they simply need review :)

> Acked-by: Cornelia Huck <cohuck@redhat.com>

Thanks,

Phil.

Re: [PATCH] tests/acceptance/virtio_check_params: Disable test

[Wainer dos Santos Moschetta]

On 2/6/20 3:17 PM, Philippe Mathieu-Daudé wrote:
> This test fails on various CI:


What CI(s) you mean?

Afaik the acceptance tests are executed only on Travis


>
> - Using QEMU 4.0:
>
>    tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias:  ERROR: 'alias-of' (0.45 s)
>
> - On OSX
>
>     Unexpected error in object_property_find() at qom/object.c:1201:
>     qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found
>
> - When removing unavailable machine:
>
>    VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x not in list (0.12 s)
>
> - Using Xen:
>
>    xencall: error: Could not obtain handle on privileged command interface: No such file or directory
>    xen be core: xen be core: can't open xen interface
>
> - On PPC:
>
>    TestFail: machine type pseries-2.8: No Transactional Memory support in TCG, try appending -machine cap-htm=off
>
> - On S390X:
>
>    ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 'virtio-scsi-pci' is not a valid device model name
>
> Disable it for now.
>
> Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Series fixing the errors:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
> ---
>   tests/acceptance/virtio_check_params.py | 2 ++

Sorry, I'm a little lost here. I can't see 
tests/acceptance/virtio_check_params.py on master. Are you patching upon 
another series?

thanks,

- Wainer

>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py
> index d5f345f75e..87e6c839d1 100644
> --- a/tests/acceptance/virtio_check_params.py
> +++ b/tests/acceptance/virtio_check_params.py
> @@ -25,6 +25,7 @@ import logging
>   sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
>   from qemu.machine import QEMUMachine
>   from avocado_qemu import Test
> +from avocado import skip
>   
>   #list of machine types and virtqueue properties to test
>   VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'}
> @@ -116,6 +117,7 @@ class VirtioMaxSegSettingsCheck(Test):
>               return True
>           return False
>   
> +    @skip("break multi-arch CI")
>       def test_machine_types(self):
>           # collect all machine types except 'none', 'isapc', 'microvm'
>           with QEMUMachine(self.qemu_bin) as vm:

Re: [PATCH] tests/acceptance/virtio_check_params: Disable test

[Philippe Mathieu-Daudé]

On 2/7/20 1:53 PM, Wainer dos Santos Moschetta wrote:
> 
> On 2/6/20 3:17 PM, Philippe Mathieu-Daudé wrote:
>> This test fails on various CI:
> 
> 
> What CI(s) you mean?
> 
> Afaik the acceptance tests are executed only on Travis

AFAIK maintainers doesn't have to have all their tests public, but are 
encouraged to share them.

Due to patches missing review by other maintainers, and getting merged 
via other trees, I'm still waiting to post some of them (in particular 
Cirrus-CI).

I run my tests on Linux (X86/Aarch64 always, PPC/S390X/MIPS often), 
FreeBSD/OSX (X86).

Before disabling this test, I tried to fix it:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
But got no review from the developers during 1 full week.
I am not removing the test, I am simply disabling it, until the 
interested developers step in to fix it. I think I am being fair.

> 
>>
>> - Using QEMU 4.0:
>>
>>    
>> tests/acceptance/x86_cpu_model_versions.py:X86CPUModelAliases.test_none_alias:  
>> ERROR: 'alias-of' (0.45 s)
>>
>> - On OSX
>>
>>     Unexpected error in object_property_find() at qom/object.c:1201:
>>     qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: 
>> can't apply global virtio-blk-device.scsi=true: Property '.scsi' not 
>> found
>>
>> - When removing unavailable machine:
>>
>>    VirtioMaxSegSettingsCheck.test_machine_types: ERROR: 
>> list.remove(x): x not in list (0.12 s)
>>
>> - Using Xen:
>>
>>    xencall: error: Could not obtain handle on privileged command 
>> interface: No such file or directory
>>    xen be core: xen be core: can't open xen interface
>>
>> - On PPC:
>>
>>    TestFail: machine type pseries-2.8: No Transactional Memory support 
>> in TCG, try appending -machine cap-htm=off
>>
>> - On S390X:
>>
>>    ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 
>> 'virtio-scsi-pci' is not a valid device model name
>>
>> Disable it for now.
>>
>> Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Series fixing the errors:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675074.html
>> ---
>>   tests/acceptance/virtio_check_params.py | 2 ++
> 
> Sorry, I'm a little lost here. I can't see 
> tests/acceptance/virtio_check_params.py on master. Are you patching upon 
> another series?

Based on the patches I extracted here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg677487.html

> 
> thanks,
> 
> - Wainer
> 
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/acceptance/virtio_check_params.py 
>> b/tests/acceptance/virtio_check_params.py
>> index d5f345f75e..87e6c839d1 100644
>> --- a/tests/acceptance/virtio_check_params.py
>> +++ b/tests/acceptance/virtio_check_params.py
>> @@ -25,6 +25,7 @@ import logging
>>   sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 
>> 'python'))
>>   from qemu.machine import QEMUMachine
>>   from avocado_qemu import Test
>> +from avocado import skip
>>   #list of machine types and virtqueue properties to test
>>   VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'}
>> @@ -116,6 +117,7 @@ class VirtioMaxSegSettingsCheck(Test):
>>               return True
>>           return False
>> +    @skip("break multi-arch CI")
>>       def test_machine_types(self):
>>           # collect all machine types except 'none', 'isapc', 'microvm'
>>           with QEMUMachine(self.qemu_bin) as vm:
>