From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-block@nongnu.org
Subject: Re: [PATCH] tests: skip block layer tests if !CONFIG_TOOLS
Date: Wed, 11 Dec 2019 15:45:12 +0100 [thread overview]
Message-ID: <2bf62e63-5f05-49bd-17f6-aa3754561491@redhat.com> (raw)
In-Reply-To: <1576074293-53357-1-git-send-email-pbonzini@redhat.com>
On 11/12/2019 15.24, Paolo Bonzini wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The block tests, as well as ahci-test needs qemu-img. Do not run
> them if it wasn't built.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/Makefile.include | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 8566f5f..f07c761 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -169,7 +169,9 @@ check-qtest-pci-$(CONFIG_IVSHMEM_DEVICE) += tests/ivshmem-test$(EXESUF)
> check-qtest-i386-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
> check-qtest-i386-y += tests/fdc-test$(EXESUF)
> check-qtest-i386-y += tests/ide-test$(EXESUF)
> +ifeq ($(CONFIG_TOOLS),y)
> check-qtest-i386-y += tests/ahci-test$(EXESUF)
> +endif
Please use "check-qtest-i386-$(CONFIG_TOOLS) += ..." instead.
Thomas
prev parent reply other threads:[~2019-12-11 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 14:24 [PATCH] tests: skip block layer tests if !CONFIG_TOOLS Paolo Bonzini
2019-12-11 14:45 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bf62e63-5f05-49bd-17f6-aa3754561491@redhat.com \
--to=thuth@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).