From: "Ján Poctavek" <jan.poctavek@erigones.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] wrong ioctl error handling on dirty pages sync?
Date: Mon, 4 Sep 2017 14:52:57 +0200 [thread overview]
Message-ID: <2bfb1acd-cd69-a719-0c18-a5684367da04@erigones.com> (raw)
In-Reply-To: <20170829100806.GO25960@stefanha-x1.localdomain>
On 29. 8. 2017 12:08, Stefan Hajnoczi wrote:
> On Fri, Aug 25, 2017 at 01:42:55PM +0200, Ján Poctavek wrote:
>> Hi guys,
>>
>> Maybe it is just my lack of understanding, this seems like a bug to me:
>>
>> To get list of dirty pages, qemu calls kvm_vm_ioctl() with
>> KVM_GET_DIRTY_LOG:
>> https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L494
>>
>> and considers the ioctl call failed when -1 is returned.
>>
>> But the kvm_vm_ioctl() itself returns -errno, not the -1 on error:
>> https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L2142
>>
>> Thanks in advance for sheding some light into this for me.
> Looks like a bug to me. Do you want to send a patch?
>
> Guidelines on how to submit a patch are here:
> http://wiki.qemu.org/Contribute/SubmitAPatch
>
> Stefan
It seems that the patch has already been created a long time ago. But it
is still not included:
https://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg03996.html
Can I help with this somehow?
Jan
next prev parent reply other threads:[~2017-09-04 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 11:42 [Qemu-devel] wrong ioctl error handling on dirty pages sync? Ján Poctavek
2017-08-29 10:08 ` Stefan Hajnoczi
2017-09-04 12:52 ` Ján Poctavek [this message]
2017-09-05 10:33 ` Stefan Hajnoczi
2017-09-05 11:57 ` Michael Tokarev
2017-09-05 11:59 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bfb1acd-cd69-a719-0c18-a5684367da04@erigones.com \
--to=jan.poctavek@erigones.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).