qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	qemu-devel@nongnu.org, "Joel Stanley" <joel@jms.id.au>
Cc: Bin Meng <bin.meng@windriver.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Subject: Re: [PATCH 22/32] hw/sd: Add emmc_cmd_SEND_EXT_CSD() handler
Date: Thu, 20 Jun 2024 11:54:45 +0200	[thread overview]
Message-ID: <2c043e6e-e685-44fb-a231-e59d7ba89234@linaro.org> (raw)
In-Reply-To: <20230703132509.2474225-23-clg@kaod.org>

On 3/7/23 15:24, Cédric Le Goater wrote:
> The parameters mimick a real 4GB eMMC, but it can be set to various
> sizes. Initially from Vincent Palatin <vpalatin@chromium.org>
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/sd/sdmmc-internal.h |  97 ++++++++++++++++++++++++++++++++++++
>   include/hw/sd/sd.h     |   1 +
>   hw/sd/sd.c             | 109 ++++++++++++++++++++++++++++++++++++++++-
>   3 files changed, 206 insertions(+), 1 deletion(-)


> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 51e2254728a6..212658050441 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -141,6 +141,7 @@ struct SDState {
>       uint64_t data_start;
>       uint32_t data_offset;
>       uint8_t data[512];
> +    uint8_t ext_csd[512];

Since the SWITCH command writes to EXT_CSD, this array must be
migrated.

>       qemu_irq readonly_cb;
>       qemu_irq inserted_cb;
>       QEMUTimer *ocr_power_timer;
> @@ -414,8 +415,85 @@ static const uint8_t sd_csd_rw_mask[16] = {
>       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfc, 0xfe,
>   };
>   
> +static void mmc_set_ext_csd(SDState *sd, uint64_t size)
> +{
> +    uint32_t sectcount = size >> HWBLOCK_SHIFT;
> +
> +    memset(sd->ext_csd, 0, sizeof(sd->ext_csd));
> +
> +    sd->ext_csd[EXT_CSD_S_CMD_SET] = 0x1; /* supported command sets */
> +    sd->ext_csd[EXT_CSD_HPI_FEATURES] = 0x3; /* HPI features  */
> +    sd->ext_csd[EXT_CSD_BKOPS_SUPPORT] = 0x1; /* Background operations */
> +    sd->ext_csd[241] = 0xA; /* 1st initialization time after partitioning */
> +    sd->ext_csd[EXT_CSD_TRIM_MULT] = 0x1; /* Trim multiplier */
> +    sd->ext_csd[EXT_CSD_SEC_FEATURE_SUPPORT] = 0x15; /* Secure feature */
> +    sd->ext_csd[EXT_CSD_SEC_ERASE_MULT] = 0x96; /* Secure erase support */
> +    sd->ext_csd[EXT_CSD_SEC_TRIM_MULT] = 0x96; /* Secure TRIM multiplier */
> +    sd->ext_csd[EXT_CSD_BOOT_INFO] = 0x7; /* Boot information */
> +    sd->ext_csd[EXT_CSD_BOOT_MULT] = 0x8; /* Boot partition size. 128KB unit */
> +    sd->ext_csd[EXT_CSD_ACC_SIZE] = 0x6; /* Access size */
> +    sd->ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE] = 0x4; /* HC Erase unit size */
> +    sd->ext_csd[EXT_CSD_ERASE_TIMEOUT_MULT] = 0x1; /* HC erase timeout */
> +    sd->ext_csd[EXT_CSD_REL_WR_SEC_C] = 0x1; /* Reliable write sector count */
> +    sd->ext_csd[EXT_CSD_HC_WP_GRP_SIZE] = 0x4; /* HC write protect group size */
> +    sd->ext_csd[EXT_CSD_S_C_VCC] = 0x8; /* Sleep current VCC  */
> +    sd->ext_csd[EXT_CSD_S_C_VCCQ] = 0x7; /* Sleep current VCCQ */
> +    sd->ext_csd[EXT_CSD_S_A_TIMEOUT] = 0x11; /* Sleep/Awake timeout */
> +    sd->ext_csd[215] = (sectcount >> 24) & 0xff; /* Sector count */
> +    sd->ext_csd[214] = (sectcount >> 16) & 0xff; /* ... */
> +    sd->ext_csd[213] = (sectcount >> 8) & 0xff;  /* ... */
> +    sd->ext_csd[EXT_CSD_SEC_CNT] = (sectcount & 0xff);       /* ... */
> +    sd->ext_csd[210] = 0xa; /* Min write perf for 8bit@52Mhz */
> +    sd->ext_csd[209] = 0xa; /* Min read perf for 8bit@52Mhz  */
> +    sd->ext_csd[208] = 0xa; /* Min write perf for 4bit@52Mhz */
> +    sd->ext_csd[207] = 0xa; /* Min read perf for 4bit@52Mhz */
> +    sd->ext_csd[206] = 0xa; /* Min write perf for 4bit@26Mhz */
> +    sd->ext_csd[205] = 0xa; /* Min read perf for 4bit@26Mhz */
> +    sd->ext_csd[EXT_CSD_PART_SWITCH_TIME] = 0x1;
> +    sd->ext_csd[EXT_CSD_OUT_OF_INTERRUPT_TIME] = 0x1;
> +    sd->ext_csd[EXT_CSD_CARD_TYPE] = 0x7;
> +    sd->ext_csd[EXT_CSD_STRUCTURE] = 0x2;
> +    sd->ext_csd[EXT_CSD_REV] = 0x5;
> +    sd->ext_csd[EXT_CSD_RPMB_MULT] = 0x1; /* RPMB size */
> +    sd->ext_csd[EXT_CSD_PARTITION_SUPPORT] = 0x3;
> +    sd->ext_csd[159] = 0x00; /* Max enhanced area size */
> +    sd->ext_csd[158] = 0x00; /* ... */
> +    sd->ext_csd[157] = 0xEC; /* ... */
> +}



  parent reply	other threads:[~2024-06-20  9:56 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 13:24 [PATCH 00/32] hw/sd: eMMC support Cédric Le Goater
2023-07-03 13:24 ` [PATCH 01/32] hw/sd: When card is in wrong state, log which state it is Cédric Le Goater
2023-07-03 13:24 ` [PATCH 02/32] hw/sd: When card is in wrong state, log which spec version is used Cédric Le Goater
2023-07-03 13:24 ` [PATCH 03/32] hw/sd: Move proto_name to SDProto structure Cédric Le Goater
2023-07-03 13:24 ` [PATCH 04/32] hw/sd: Introduce sd_cmd_handler type Cédric Le Goater
2023-07-03 13:24 ` [PATCH 05/32] hw/sd: Add sd_cmd_illegal() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 06/32] hw/sd: Add sd_cmd_unimplemented() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 07/32] hw/sd: Add sd_cmd_GO_IDLE_STATE() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 08/32] hw/sd: Add sd_cmd_SEND_OP_CMD() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 09/32] hw/sd: Add sd_cmd_ALL_SEND_CID() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 10/32] hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 11/32] hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 12/32] hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 13/32] hw/sd: Introduce a "sd-card" SPI variant model Cédric Le Goater
2023-08-28 17:11   ` Philippe Mathieu-Daudé
2023-07-03 13:24 ` [PATCH 14/32] hw/sd: Basis for eMMC support Cédric Le Goater
2023-07-03 13:24 ` [PATCH 15/32] hw/sd: Add emmc_cmd_SEND_OP_CMD() handler Cédric Le Goater
2024-06-03 12:25   ` Philippe Mathieu-Daudé
2024-06-03 12:27     ` Philippe Mathieu-Daudé
2023-07-03 13:24 ` [PATCH 16/32] hw/sd: Add emmc_cmd_ALL_SEND_CID() handler Cédric Le Goater
2024-06-03 12:18   ` Philippe Mathieu-Daudé
2023-07-03 13:24 ` [PATCH 17/32] hw/sd: Add emmc_cmd_SEND_RELATIVE_ADDR() handler Cédric Le Goater
2024-06-03 12:26   ` Philippe Mathieu-Daudé
2024-06-04 15:13     ` Cédric Le Goater
2023-07-03 13:24 ` [PATCH 18/32] hw/sd: Add emmc_cmd_APP_CMD() handler Cédric Le Goater
2024-06-25 15:04   ` Philippe Mathieu-Daudé
2024-06-25 15:13     ` Cédric Le Goater
2024-06-25 15:32       ` Philippe Mathieu-Daudé
2024-06-25 15:54         ` Cédric Le Goater
2023-07-03 13:24 ` [PATCH 19/32] hw/sd: add emmc_cmd_SEND_TUNING_BLOCK() handler Cédric Le Goater
2023-07-03 13:24 ` [PATCH 20/32] hw/sd: Add CMD21 tuning sequence Cédric Le Goater
2024-06-12 22:15   ` Philippe Mathieu-Daudé
2024-06-12 22:37     ` Philippe Mathieu-Daudé
2023-07-03 13:24 ` [PATCH 21/32] hw/sd: Add mmc switch function support Cédric Le Goater
2024-06-12 22:49   ` Philippe Mathieu-Daudé
2024-06-13  7:44     ` Cédric Le Goater
2024-06-13  8:41       ` Philippe Mathieu-Daudé
2023-07-03 13:24 ` [PATCH 22/32] hw/sd: Add emmc_cmd_SEND_EXT_CSD() handler Cédric Le Goater
2024-06-19 17:40   ` Philippe Mathieu-Daudé
2024-06-20  7:23     ` Cédric Le Goater
2024-06-20 10:24       ` Philippe Mathieu-Daudé
2024-06-20  9:54   ` Philippe Mathieu-Daudé [this message]
2023-07-03 13:25 ` [PATCH 23/32] hw/sd: Support boot area in emmc image Cédric Le Goater
2023-07-03 13:25 ` [PATCH 24/32] hw/sd: Subtract bootarea size from blk Cédric Le Goater
2024-06-03 12:31   ` Philippe Mathieu-Daudé
2024-06-04 15:21     ` Cédric Le Goater
2023-07-03 13:25 ` [PATCH 25/32] hw/sd: Add boot config support Cédric Le Goater
2023-07-03 13:25 ` [PATCH 26/32] hw/sd: Fix SET_BLOCK_COUNT command argument Cédric Le Goater
2024-06-12 22:23   ` Philippe Mathieu-Daudé
2023-07-03 13:25 ` [PATCH 27/32] hw/sd: Update CMD1 definition for MMC Cédric Le Goater
2023-07-03 13:25 ` [PATCH 28/32] hw/arm/aspeed: Add eMMC device Cédric Le Goater
2023-07-03 13:25 ` [PATCH 29/32] hw/arm/aspeed: Load eMMC first boot area as a boot rom Cédric Le Goater
2023-07-03 13:25 ` [PATCH 30/32] hw/arm/aspeed: Set boot device to emmc Cédric Le Goater
2023-07-03 13:25 ` [PATCH 31/32] aspeed: Set bootconfig Cédric Le Goater
2023-07-03 13:25 ` [PATCH 32/32] aspeed: Introduce a 'boot-emmc' property for AST2600 based machines Cédric Le Goater
2023-08-28 16:27 ` [PATCH 00/32] hw/sd: eMMC support Cédric Le Goater
2024-05-21 10:59   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c043e6e-e685-44fb-a231-e59d7ba89234@linaro.org \
    --to=philmd@linaro.org \
    --cc=bin.meng@windriver.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=lucienmp.qemu@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).