From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bXyMB-0002VR-GW
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 18:21:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bXyM9-0000Dn-JR
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 18:21:42 -0400
Sender: Richard Henderson <rth7680@gmail.com>
References: <1470891017-5800-1-git-send-email-famz@redhat.com>
	<1470891017-5800-2-git-send-email-famz@redhat.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <2c193764-6c6a-25fe-f59d-9a5fd9fa838d@twiddle.net>
Date: Thu, 11 Aug 2016 23:21:28 +0100
MIME-Version: 1.0
In-Reply-To: <1470891017-5800-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/9] util: Add UUID API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com

On 08/11/2016 05:50 AM, Fam Zheng wrote:
> +void qemu_uuid_bswap(QemuUUID *uuid)
> +{
> +    bswap32s((uint32_t *)&uuid->data[0]);
> +    bswap16s((uint16_t *)&uuid->data[4]);
> +    bswap16s((uint16_t *)&uuid->data[6]);
> +}

You have alignment problems here too.  Perhaps you really did want to add 
uint32_t (and uint16_t?) as union members to QemuUUID.


r~