From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3Rzw-0005oC-8n for qemu-devel@nongnu.org; Wed, 26 Apr 2017 14:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3Rzq-000452-D2 for qemu-devel@nongnu.org; Wed, 26 Apr 2017 14:49:08 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47275 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d3Rzq-00044F-5y for qemu-devel@nongnu.org; Wed, 26 Apr 2017 14:49:02 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v3QImlJQ022751 for ; Wed, 26 Apr 2017 14:49:00 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2a2ebv33fc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 26 Apr 2017 14:49:00 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Apr 2017 14:49:00 -0400 References: <20170426183721.7482-1-dgilbert@redhat.com> <20170426183721.7482-3-dgilbert@redhat.com> From: Christian Borntraeger Date: Wed, 26 Apr 2017 20:48:55 +0200 MIME-Version: 1.0 In-Reply-To: <20170426183721.7482-3-dgilbert@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Message-Id: <2c1ca003-807a-828f-f16b-ed5f4ae19f47@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/2] migration: Extra tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, quintela@redhat.com, lvivier@redhat.com, peterx@redhat.com On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > A couple more traces that would have made fixing that postcopy > bug a bit easier. > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Christian Borntraeger > --- > migration/ram.c | 2 ++ > migration/trace-events | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index b4ed41c725..3ac41ccaba 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -812,6 +812,7 @@ static int ram_save_page(RAMState *rs, PageSearchStatus *pss, bool last_stage) > ram_addr_t offset = pss->page << TARGET_PAGE_BITS; > > p = block->host + offset; > + trace_ram_save_page(block->idstr, (uint64_t)offset, p); > > /* In doubt sent page as normal */ > bytes_xmit = 0; > @@ -2614,6 +2615,7 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id) > ret = -EINVAL; > break; > } > + trace_ram_load_loop(block->idstr, (uint64_t)addr, flags, host); > } > > switch (flags & ~RAM_SAVE_FLAG_CONTINUE) { > diff --git a/migration/trace-events b/migration/trace-events > index b8f01a218c..5b8ccf301c 100644 > --- a/migration/trace-events > +++ b/migration/trace-events > @@ -69,8 +69,10 @@ migration_bitmap_sync_start(void) "" > migration_bitmap_sync_end(uint64_t dirty_pages) "dirty_pages %" PRIu64 > migration_throttle(void) "" > ram_discard_range(const char *rbname, uint64_t start, size_t len) "%s: start: %" PRIx64 " %zx" > +ram_load_loop(const char *rbname, uint64_t addr, int flags, void *host) "%s: addr: %" PRIx64 " flags: %x host: %p" > ram_load_postcopy_loop(uint64_t addr, int flags) "@%" PRIx64 " %x" > ram_postcopy_send_discard_bitmap(void) "" > +ram_save_page(const char *rbname, uint64_t offset, void *host) "%s: offset: %" PRIx64 " host: %p" > ram_save_queue_pages(const char *rbname, size_t start, size_t len) "%s: start: %zx len: %zx" > > # migration/migration.c >