From: Eric Blake <eblake@redhat.com>
To: Chen Hanxiao <chen_han_xiao@126.com>, qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qga: add mountpoint usage to GuestFilesystemInfo
Date: Tue, 29 May 2018 22:20:00 -0500 [thread overview]
Message-ID: <2c1d1ac1-9f00-7469-b36b-2bb62de87b9a@redhat.com> (raw)
In-Reply-To: <38cf2387-bbac-e4e8-4c7f-d7ba9bdcd0e2@redhat.com>
On 05/29/2018 10:19 PM, Eric Blake wrote:
>> @@ -846,13 +846,14 @@
>> # @name: disk name
>> # @mountpoint: mount point path
>> # @type: file system type string
>> +# @usage: file system usage
>
> Needs more details. As written, it is an integer between 0 and 100; but
> if you use floating point, a better description would be a fraction
> between 0 and 1.
Also, missing a '(since 3.0)' designation.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-30 3:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 3:01 [Qemu-devel] [PATCH] qga: add mountpoint usage to GuestFilesystemInfo Chen Hanxiao
2018-05-30 3:19 ` Eric Blake
2018-05-30 3:20 ` Eric Blake [this message]
2018-05-30 6:55 ` Chen Hanxiao
2018-05-30 13:05 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1d1ac1-9f00-7469-b36b-2bb62de87b9a@redhat.com \
--to=eblake@redhat.com \
--cc=chen_han_xiao@126.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).