From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D705CA9EAF for ; Mon, 21 Oct 2019 17:06:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27A512064B for ; Mon, 21 Oct 2019 17:06:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S0Ku+pq5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27A512064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMb8B-0002kc-Ca for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 13:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42153) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMb6l-0001GS-FC for qemu-devel@nongnu.org; Mon, 21 Oct 2019 13:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMb6k-0004H0-EH for qemu-devel@nongnu.org; Mon, 21 Oct 2019 13:04:39 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:46765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMb6k-0004Gd-63 for qemu-devel@nongnu.org; Mon, 21 Oct 2019 13:04:38 -0400 Received: by mail-pf1-x441.google.com with SMTP id q5so8786545pfg.13 for ; Mon, 21 Oct 2019 10:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sk2t83DjkVWnrtVbQf47uSIW5xeeBnZ573CRkaV10g0=; b=S0Ku+pq5NlWbBoNo2FojBvVxjVFT8KjyO0EzQ1JMqCjGJBiaOxtCYVKfj00/CDGtCL Ze536vX9i8Ub9XXWEcQIStEfnOAgC6GmHACwstfl94FhSkUENCiYSjH/fDgJmsTLsvYC lbWu/haXJqQFsa7zvliY4LI58lPWjuTsYCi/6IHSL6sb2E/C4pPXj2KSmp41tm6caG68 WHAYktSXFRhcEb5G3SqlH7bpFFXb7EBkHeaCfVDfKwrJq+JS1XKKvaKMpV0+Y39zLnk1 Z6RHNsjiBMNijSlizPwu9pUQXwL1qpO2ZFcuQTw+oc4TN6lJkVK+CNEg0uiuQg26qYw7 9GCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sk2t83DjkVWnrtVbQf47uSIW5xeeBnZ573CRkaV10g0=; b=DJNHOX/D2TmmXfL0imnyptKiSqi9kwaTVgXwRT3o6DsewV1gCAcMhr44z3gEyN/+tq 1YqrN0QlWXR6JFyqUkeJgoS8s6Pzg7JlQCpkCoPH1vO+C6TXXt74GmDZwTHeMFqJQ/ms /GhMm2cPL3wHamBFxtVzLU1a9DAXy7+rDhJS8o++jZCshMuCdVoWKdTbo1RsAWWjqqgr sYVpLvKpLBPhjOSpR2vp25D+WEDkhpR4fnlfUwCkBXe7yPhrZoDgV49oeBiols8qOTCm sOB+J+IJoXNw6rLPzVcNIc0qpz5caM/8S97xFrXuk8Z5AexqQrefkUdmMae6c9Qej70c xbVg== X-Gm-Message-State: APjAAAVOWcz018CW1K5jz/z4T38gzdBCSjRHnIxWZfs8zIuEFX9Qvskh sZAsvJaABIt6iGl7UcR8O38Jrw== X-Google-Smtp-Source: APXvYqxlbxQO5DONqV4XwcPtgzRUI9gs88526kuUY4KJ1RGOtY+sdrwah6fdbmQfWtH7xGtbjeN88w== X-Received: by 2002:a65:64da:: with SMTP id t26mr26521521pgv.180.1571677476828; Mon, 21 Oct 2019 10:04:36 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id s3sm14619998pjq.32.2019.10.21.10.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Oct 2019 10:04:36 -0700 (PDT) Subject: Re: [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Markus Armbruster , Eduardo Habkost References: <20191020225650.3671-1-philmd@redhat.com> <20191020225650.3671-7-philmd@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <2c557278-8696-3e6b-31ef-00850f48a224@linaro.org> Date: Mon, 21 Oct 2019 10:04:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191020225650.3671-7-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , "Michael S. Tsirkin" , Leif Lindholm , Andrew Jeffery , Mark Cave-Ayland , KONRAD Frederic , "Edgar E. Iglesias" , Rob Herring , Peter Maydell , Helge Deller , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Antony Pavlov , Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Joel Stanley , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Richard Henderson , Radoslaw Biernacki , Thomas Huth , Andrew Baumann , Jean-Christophe Dubois , Andrey Smirnov , Michael Walle , qemu-ppc@nongnu.org, Aleksandar Markovic , Jan Kiszka , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > Having the RAM creation code in a separate function is not > very helpful. Move this code directly inside the board_init() > function, this will later allow the board to have the QOM > ownership of the RAM. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/digic_boards.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~