From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7A9C4740C for ; Mon, 9 Sep 2019 14:06:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D54218DE for ; Mon, 9 Sep 2019 14:06:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3D54218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7KJj-0005mW-S4 for qemu-devel@archiver.kernel.org; Mon, 09 Sep 2019 10:06:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37261) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7KIo-0004rP-2w for qemu-devel@nongnu.org; Mon, 09 Sep 2019 10:05:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7KIn-0004iI-33 for qemu-devel@nongnu.org; Mon, 09 Sep 2019 10:05:57 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:45993) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i7KIm-0004g9-QW for qemu-devel@nongnu.org; Mon, 09 Sep 2019 10:05:57 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MFK8N-1hwbyj3BCz-00Fkhx; Mon, 09 Sep 2019 16:05:36 +0200 To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20190830143648.2967-1-alex.bennee@linaro.org> <87sgp51sel.fsf@linaro.org> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <2c63a5cd-ffb3-fb7e-e3ea-54a938a28f90@vivier.eu> Date: Mon, 9 Sep 2019 16:05:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87sgp51sel.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:MDKZkKyVmxYgebWIPPu++FPCUJXJaHgPMoGB0N/Ep9PIYwrvWl5 sPG1cxyB814S/+yFlgcaBREf/xnYt9GQlg24ratCEe4iXGkmLay7lstino8cUsmdofGKRNs 3lUyeuzSaaWMwgSd4+nCsqg4Doy7zVTaAM5ZBKBhfFI//oKZUlXABwxenUx5OJWjWhDU30I WS+ePLjkqxEoLyg2fnIrg== X-UI-Out-Filterresults: notjunk:1;V03:K0:zNPMTYbQIjM=:Do2CttNb0oOS3jU8ix4QYZ CiKG91Aa9oIcc+gmmJ0XnXH+EQoJ+kfqxylQEM3PIiR7fkEvdBKiWqVcPpeNOt+F65ngYDaB0 O8mSXlige4MY3yO/bMXgZmREGJ+O9sIXmKMvkNqrvLqOfKtrVi+X+ujgLLNAGL1w7x6cEv8PJ yTw5++faj7L6KdV1RrIUGT+C1wA80SrLee/f0SLQ4HJgmCb18HtlfYDGBWY3mHsQWWy1emnPh ivSbDGQattnIPSg+3fZ5kFBBYIcAxEXuQzAuxydvmFsgR1PH8ycIQY0m6W/uUcLO/ztT/d0Z8 FFcVTMvncMoYgnkPJOeyHCme1MvaayJyBnOrbxhPZ7+D7scvR/X/oyURu7xcvlXtp6LLpbvkJ k3cpSSunyl1TeI91ViwCh2cvSUwYcX90afHSaZGhxY5Mo1Bs1WBQskBVxWpkjJeU3VF2p8MY9 OkvLTQO8NJbBX8II4GhpuE3bmwJhUsfG/lypMWoJQ3EYxU+cc7EP2gLY7WsFpde1SHgK2NemM KCnA87z3Why8cLKuv6FaotxLT0DIt7zmtml4wqhCApQxeqsX09OR+PFES8Q46SXeSxRZJAHnP a1CXXKFyG01CTZYQ3v92/ZN6Mcm8oU4Hq/yHl3ukoAMwRenpQ2dJVVWtvoZYBOO3+zD3Fqeru 7K5Cl87d/44pQOgGoHjfR+jYgmubpSNUpQ7qioadgpPE9F3AmJSUceHJ9V7zkjiTEGb/OtdHN /NfMep1ttzmbgO/712zGi5lasm4Xj41GTyHzUK2AdMh2HZTa0URRrc+etloPHiWPNlLZA05C7 VVJk3LporDL7q/6robvH8lMM4GvMh6M2Fv5YnONkDlFDbXu/Mo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.75 Subject: Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 09/09/2019 à 16:00, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 30/08/2019 à 16:36, Alex Bennée a écrit : >>> Just passing NULL means we end up ignoring the bad dfilter spec >>> instead of reporting it and exiting as we should. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> linux-user/main.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/linux-user/main.c b/linux-user/main.c >>> index 47917bbb20f..50a031520ca 100644 >>> --- a/linux-user/main.c >>> +++ b/linux-user/main.c >>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg) >>> >>> static void handle_arg_dfilter(const char *arg) >>> { >>> - qemu_set_dfilter_ranges(arg, NULL); >>> + qemu_set_dfilter_ranges(arg, &error_fatal); >>> } >>> >>> static void handle_arg_log_filename(const char *arg) >>> >> >> Reviewed-by: Laurent Vivier > > Did you queue this or do you want me to resend? I didn't but it's done now (no need to resend). Thanks, Laurent