From: Laurent Vivier <lvivier@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Richard W . M . Jones" <rjones@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom`
Date: Tue, 14 May 2019 10:15:31 +0200 [thread overview]
Message-ID: <2c68e2a2-384b-e107-03ff-42d09df558a7@redhat.com> (raw)
In-Reply-To: <20190514080854.GD17214@paraplu>
On 14/05/2019 10:08, Kashyap Chamarthy wrote:
> On Tue, May 14, 2019 at 09:56:00AM +0200, Laurent Vivier wrote:
>> From: Kashyap Chamarthy <kchamart@redhat.com>
>>
>> When QEMU exposes a VirtIO-RNG device to the guest, that device needs a
>> source of entropy, and that source needs to be "non-blocking", like
>> `/dev/urandom`. However, currently QEMU defaults to the problematic
>> `/dev/random`, which on linux is "blocking" (as in, it waits until
>
> OCD nit: s/linux/Linux/
>
> Maybe Michael can do the touch up when applying.
A little reminder: this patch can be applied alone, but the followings
need the series from Richard to be applied first.
Thanks,
Laurent
next prev parent reply other threads:[~2019-05-14 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:55 [Qemu-devel] [PATCH v4 0/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() Laurent Vivier
2019-05-14 7:56 ` [Qemu-devel] [PATCH v4 1/3] VirtIO-RNG: Update default entropy source to `/dev/urandom` Laurent Vivier
2019-05-14 8:08 ` Kashyap Chamarthy
2019-05-14 8:15 ` Laurent Vivier [this message]
2019-05-14 13:49 ` Markus Armbruster
2019-05-14 14:43 ` Markus Armbruster
2019-05-14 7:56 ` [Qemu-devel] [PATCH v4 2/3] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() Laurent Vivier
2019-05-14 14:50 ` Markus Armbruster
2019-05-14 7:56 ` [Qemu-devel] [PATCH v4 3/3] virtio-rng: change default backend to rng-builtin Laurent Vivier
2019-05-14 15:24 ` Markus Armbruster
2019-05-14 15:28 ` Laurent Vivier
2019-05-14 15:19 ` [Qemu-devel] [PATCH 3.5/4] virtio-rng: Keep the default backend out of VirtIORNGConf Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c68e2a2-384b-e107-03ff-42d09df558a7@redhat.com \
--to=lvivier@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kchamart@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).