Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

["Hervé Poussineau" <hpoussin@reactos.org>]

Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
> From: Laurent Vivier <laurent@vivier.eu>
> 
> On Sparc and PowerMac, the bit 0 of the address
> selects the register type (control or data) and
> bit 1 selects the channel (B or A).
> 
> On m68k Macintosh, the bit 0 selects the channel and
> bit 1 the register type.
> 
> This patch introduces a new parameter (bit_swap) to
> the device interface to indicate bits usage must
> be swapped between registers and channels.
> 
> For the moment all the machines use the bit 0,
> but this change will be needed to emulate Quadra 800.
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>   hw/char/escc.c         | 30 ++++++++++++++++++++++++------
>   include/hw/char/escc.h |  1 +
>   2 files changed, 25 insertions(+), 6 deletions(-)

Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>