From: Sebastian Bauer <mail@sebastianbauer.info>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.
Date: Fri, 26 Oct 2012 17:10:53 +0200 [thread overview]
Message-ID: <2c7709acb10525c7c9365fabe1216e7a@sebastianbauer.info> (raw)
In-Reply-To: <508A7B69.8050003@redhat.com>
Hi!
Am 26.10.2012 14:00, schrieb Gerd Hoffmann:
> Wrong fix I think. Just moving "port->portsc |= PORTSC_CSC" out of
> the
> "if (running)" should do. usb-next already has a patch which fixes
> this:
I'm not sure about that. According to the spec, when the hc is set to
running mode (p.70)
"At this point, the host controller is up and running and the Root Hub
ports (5.4.8) will begin reporting device
connects"
Therefore I made it slightly more complex. Granted, as far as I can
see, the spec doesn't explicitly state that the devices are not reported
when being not in the running mode.
It probably would be easier to mask out relevant bits when reading the
port registers if the hcd would be strict.
>
> http://www.kraxel.org/cgit/qemu/commit/?h=rebase/usb-next&id=84f84686c701731964a515e9bbcfb475cfc1de8c
Nice, this wasn't there when I looked into this today. However, does
this commit also ensure that the status port change event is generated
when the hc is switched to running mode and there were already some
devices present?
Bye,
Sebastian
next prev parent reply other threads:[~2012-10-26 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 8:29 [Qemu-devel] [PATCH 0/2] xhci: Better spec conforming behaviour Sebastian Bauer
2012-10-26 8:29 ` [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached Sebastian Bauer
2012-10-26 12:00 ` Gerd Hoffmann
2012-10-26 15:10 ` Sebastian Bauer [this message]
2012-11-01 13:20 ` Gerd Hoffmann
2012-10-26 8:29 ` [Qemu-devel] [PATCH 2/2] Respond a set address command with CC_PARAMETER_ERROR, if the speed field of the input context is not valid Sebastian Bauer
2012-10-26 12:05 ` Gerd Hoffmann
2012-10-26 11:53 ` [Qemu-devel] [PATCH 0/2] xhci: Better spec conforming behaviour Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c7709acb10525c7c9365fabe1216e7a@sebastianbauer.info \
--to=mail@sebastianbauer.info \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).