qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
	pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com,
	Beraldo Leal <bleal@redhat.com>,
	Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
Subject: Re: [PATCH v2 5/6] tests/docker: use prebuilt toolchain for debian-hexagon-cross
Date: Wed, 21 Dec 2022 10:16:06 +0100	[thread overview]
Message-ID: <2c7e81ce-fd51-e005-353f-d3bd6e37e2bc@linaro.org> (raw)
In-Reply-To: <20221221090411.1995037-6-alex.bennee@linaro.org>

On 21/12/22 10:04, Alex Bennée wrote:
> From: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
> 
> The current docker image for cross compiling hexagon guests
> is manually built since it takes >2 hours to build from source.
> 
> This patch:
>   1. Solves the above issue by using the prebuilt clang
>      toolchain hosted on CodeLinaro [1] and maintained by QUIC [2].
>   2. The dockerfile is also switched from multi-stage to single stage
>      build to allow the CI docker engine to reuse the layer cache.
>   3. Re-enables the hexagon-cross-container job to be always run in
>      CI and makes it a non-optional dependency for the
>      build-user-hexagon job.
> 
> The changes for 1 & 2 together bring down the build time to
> ~3 minutes in GitLab CI when cache is reused and ~9 minutes
> when cache cannot be reused.
> 
> [1]: https://github.com/CodeLinaro/hexagon-builder
> [2]: https://github.com/quic/toolchain_for_hexagon/releases/
> 
> Based-on: <20221215095820.13374-1-quic._5Fmthiyaga@quicinc.com>
>   tests/tcg/multiarch: remove unused variable in linux-test

Please remove this tag before sending the pull request ^

> Signed-off-by: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
> [AJB: also tweak MAINTAINERS]
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20221219144354.11659-1-quic_mthiyaga@quicinc.com>
> ---
>   .gitlab-ci.d/buildtest.yml                    |   4 -
>   .gitlab-ci.d/container-cross.yml              |  19 +--
>   MAINTAINERS                                   |   1 -
>   tests/docker/Makefile.include                 |   4 -
>   .../debian-hexagon-cross.d/build-toolchain.sh | 141 ------------------
>   .../dockerfiles/debian-hexagon-cross.docker   |  53 +++----
>   6 files changed, 20 insertions(+), 202 deletions(-)
>   delete mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.d/build-toolchain.sh



  reply	other threads:[~2022-12-21  9:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21  9:04 [PATCH v2 0/6] current status of testing/next Alex Bennée
2022-12-21  9:04 ` [PATCH v2 1/6] configure: Fix check-tcg not executing any tests Alex Bennée
2022-12-21  9:04 ` [PATCH v2 2/6] gitlab: turn off verbose logging for make check on custom runners Alex Bennée
2022-12-21  9:04 ` [PATCH v2 3/6] configure: repeat ourselves for the benefit of CI Alex Bennée
2022-12-21  9:14   ` Philippe Mathieu-Daudé
2022-12-21  9:04 ` [PATCH v2 4/6] tests/tcg: fix unused variable in linux-test Alex Bennée
2022-12-21  9:14   ` Philippe Mathieu-Daudé
2022-12-21  9:04 ` [PATCH v2 5/6] tests/docker: use prebuilt toolchain for debian-hexagon-cross Alex Bennée
2022-12-21  9:16   ` Philippe Mathieu-Daudé [this message]
2022-12-21  9:04 ` [PATCH v2 6/6] gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs Alex Bennée
2022-12-21  9:15   ` Philippe Mathieu-Daudé
2022-12-21 10:23 ` [PATCH v2 0/6] current status of testing/next Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c7e81ce-fd51-e005-353f-d3bd6e37e2bc@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_mthiyaga@quicinc.com \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).