From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Fam Zheng" <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jeff Cody" <jcody@redhat.com>,
cohuck@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL
Date: Sun, 4 Nov 2018 23:33:54 +0100 [thread overview]
Message-ID: <2c858c4a-ffb5-997f-1274-3aab0b211c50@redhat.com> (raw)
In-Reply-To: <20181104112424.18663-7-stefanha@redhat.com>
On 4/11/18 12:24, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/misc/pc-testdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/pc-testdev.c b/hw/misc/pc-testdev.c
> index 697eb88c97..0aee04f231 100644
> --- a/hw/misc/pc-testdev.c
> +++ b/hw/misc/pc-testdev.c
> @@ -32,7 +32,7 @@
> * -kernel /home/lmr/Code/virt-test.git/kvm/unittests/msr.flat
> *
> * Where msr.flat is one of the KVM unittests, present on a separate repo,
> - * git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
> + * https://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
> */
>
> #include "qemu/osdep.h"
>
next prev parent reply other threads:[~2018-11-04 22:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 11:24 [Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 1/8] README: use " Stefan Hajnoczi
2018-11-04 22:38 ` Philippe Mathieu-Daudé
2018-11-05 11:51 ` Alex Bennée
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 2/8] get_maintainer: " Stefan Hajnoczi
2018-11-04 22:37 ` Philippe Mathieu-Daudé
2018-11-08 10:55 ` Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 3/8] MAINTAINERS: use 'https://' instead of 'git://' for GitHub Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 4/8] gitmodules: use 'https://' instead of 'git://' Stefan Hajnoczi
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 5/8] git: use HTTPS git URLs for repo.or.cz Stefan Hajnoczi
2018-11-05 15:54 ` Eric Blake
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 6/8] pc-testdev: use HTTPS git URL Stefan Hajnoczi
2018-11-04 22:33 ` Philippe Mathieu-Daudé [this message]
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 7/8] target-alpha: use HTTPS git URL for palcode Stefan Hajnoczi
2018-11-04 22:34 ` Philippe Mathieu-Daudé
2018-11-05 7:08 ` Richard Henderson
2018-11-04 11:24 ` [Qemu-devel] [PATCH v3 8/8] docker: use HTTPS git URL for virglrenderer Stefan Hajnoczi
2018-11-04 22:35 ` Philippe Mathieu-Daudé
2018-11-05 12:03 ` Alex Bennée
2018-11-04 22:23 ` [Qemu-devel] [PATCH v3 0/8] Use 'https://' instead of 'git://' Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c858c4a-ffb5-997f-1274-3aab0b211c50@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).