From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmzix-0002ZM-2P for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:51:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmziv-0002FX-4o for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:51:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmziu-0002FQ-V5 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:51:17 -0400 References: <20160921113303.1420.63544.stgit@PASHA-ISP.def.inno> <20160921113315.1420.49751.stgit@PASHA-ISP.def.inno> <5d38dfa7-8a5f-a324-ad22-cdd56d288697@redhat.com> <004901d2141f$af552420$0dff6c60$@ru> <8327862c-32c6-23ad-38b2-eb7fd9cd25cc@redhat.com> <000001d21493$748b4d00$5da1e700$@ru> From: Paolo Bonzini Message-ID: <2ca7f8c9-5250-2232-da78-73f18299e6f5@redhat.com> Date: Thu, 22 Sep 2016 10:51:10 +0200 MIME-Version: 1.0 In-Reply-To: <000001d21493$748b4d00$5da1e700$@ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/8] replay: save/load initial state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , 'Pavel Dovgalyuk' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jasowang@redhat.com, quintela@redhat.com, mst@redhat.com On 22/09/2016 07:37, Pavel Dovgalyuk wrote: >> > I mean that (if I understand correctly) raw images are corrupted if you >> > don't use -snapshot (the record overwrites them, and the replay reads >> > overwritten data). > I tried running record/replay with raw image. Record finished without an error, > but replay couldn't start, because there was no snapshot to load. > I think the solution is checking savevm return code and exiting if snapshot cannot be created. Yep, good idea. Paolo