Re: [PATCH v1 06/12] hw/arm/aspeed_ast10x0: Add common realize function for AST10x0 SoCs

["Cédric Le Goater" <clg@kaod.org>]

On 11/6/25 09:49, Jamin Lin wrote:
> Introduce a new common realize function aspeed_soc_ast10x0_realize()
> for AST10x0 series SoCs. The shared initialization and realization logic
> is now placed in this common function to improve code reuse and reduce
> duplication between different SoCs in the same family.
> 
> The AST1030 realization function aspeed_soc_ast1030_realize() is
> updated to call the new common routine and then perform realization of
> its own specific devices such as LPC and PECI, which are not present on
> future SoCs like AST1060.
> 
> This refactor simplifies maintenance and prepares the framework for
> adding AST1060 support.
> 
> No functional changes.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   hw/arm/aspeed_ast10x0.c | 128 ++++++++++++++++++++++------------------
>   1 file changed, 70 insertions(+), 58 deletions(-)


LGTM,


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.