From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE923CCFA18 for ; Tue, 11 Nov 2025 18:20:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIsxi-0001XV-WE; Tue, 11 Nov 2025 13:19:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIsxH-0001LM-Oe for qemu-devel@nongnu.org; Tue, 11 Nov 2025 13:19:10 -0500 Received: from 9.mo552.mail-out.ovh.net ([87.98.180.222]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIsxE-0005tz-Qa for qemu-devel@nongnu.org; Tue, 11 Nov 2025 13:18:57 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.254.100]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id 4d5ZXv6W0Bz5w9Z; Tue, 11 Nov 2025 18:18:39 +0000 (UTC) Received: from kaod.org (37.59.142.100) by DAG8EX2.mxp5.local (172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.61; Tue, 11 Nov 2025 19:18:38 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-100R00337f595e9-a254-42c3-9434-6ccc9ad7113f, FED24A3CA347B2ADB49E2A92EE4521FA9BC47B0E) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <2cb61b9b-3bc7-48de-80be-3a9df07862a4@kaod.org> Date: Tue, 11 Nov 2025 19:18:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/12] hw/arm/aspeed_ast10x0: Add common realize function for AST10x0 SoCs To: Jamin Lin , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , Alistair Francis , Kevin Wolf , Hanna Reitz , "open list:ASPEED BMCs" , "open list:All patches CC here" , "open list:Block layer core" CC: , References: <20251106084925.1253704-1-jamin_lin@aspeedtech.com> <20251106084925.1253704-7-jamin_lin@aspeedtech.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20251106084925.1253704-7-jamin_lin@aspeedtech.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.100] X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG8EX2.mxp5.local (172.16.2.72) X-Ovh-Tracer-GUID: eb64749f-38a1-4b3f-80e7-6d441bafbbd8 X-Ovh-Tracer-Id: 9078975375324777278 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFkyaUWw8FAVf48HUio9QtaKjadHuP9j5UZpPQctpTLW7kSCO77lR9RmgLHAIqL+qxM0zfELFCVWMwUVRjyu8cPJX9fC6koHvD6ebztXbVOTXQ4jMxi74pEzAr0EqFnmIVwhGCjjP5/yBzILbrFKTWTyP9NjwkdQqRzq1qQAcBxibvq4WPRZnJtg11uuS3L23v7vxCec+FGMsQS+q/NRDnnjyPP7pVmNH4d3PXIBrSyK+gNKeG6a7UWcBM35EDjmgA7KDtyH+Hk7wcZKnMJuZwrr4U3n/ReIn7ccIVgbqEu348C1nmL4zs16nLTsjxXOvb4Dcs1QTKHJrodVUCjHly0TYBH7M96VvnphK4Es0uUogdSkbg489nKDnLJ+HPxB8Ykq7PuhxhPI3LqCNE4NUonvpELZwWXxt1vlzTpAGJ0lratdPC+j7SR79M8bKS63QQuKzsk8HM/8EGcMoi1tZSpMrMXL/KSL+G8rCERi6EVU57aOiTFNfH52GL6E6gwLyReUvZTOyRdpe/iC1ZB+kgrS/OsXSE6wS6Gv4rwgL4dNt+B6TcMyzrsBincY7ztyoj8lVuuJwT791wGaE2GIvOMfWmzfTcNg4oJrC0JgtYJDwA6p4xr3/qBQj7ZKREd2MCKcBx3K1/zoh9A8sX8d3ZYbkugnSoTuKh/OdK2e43brQ DKIM-Signature: a=rsa-sha256; bh=OCLclOcTieDPj/oH4oQEutmew3fgT9Zs9kiqq+DUSIM=; c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1; t=1762885121; v=1; b=VQ22xHo/Fz/sM+Sah7DHREdV6sG8YOTCJTqmor83LTJ4enftphiiX75Vt2ARo+reaGJRsqCv yS0sCNydzd4ijn7PSeXzKxFZ023PHMXB2qfFdQGtNL21WoZWq6k1oCwCOO+LHVi/AUVOnKW0MsP hkS4V5KrbzD6SV2w2VfST4I1Ft5bfRko6ffA2aXiFkm88bWsTpE4DeRNyfQ457/3i1uoMM2sdDa /MaV06pYv+QFShOHLV4ykKknpp6DXYUCOkHgBM6Oww+vt7cllQ9DzYJ4XXbYbcM3fodV3Na+d4r psovTPH4PrzEh5rpY6/bYbQgcYs0ozEM4Oo0AoaZYZYAA== Received-SPF: pass client-ip=87.98.180.222; envelope-from=clg@kaod.org; helo=9.mo552.mail-out.ovh.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/6/25 09:49, Jamin Lin wrote: > Introduce a new common realize function aspeed_soc_ast10x0_realize() > for AST10x0 series SoCs. The shared initialization and realization logic > is now placed in this common function to improve code reuse and reduce > duplication between different SoCs in the same family. > > The AST1030 realization function aspeed_soc_ast1030_realize() is > updated to call the new common routine and then perform realization of > its own specific devices such as LPC and PECI, which are not present on > future SoCs like AST1060. > > This refactor simplifies maintenance and prepares the framework for > adding AST1060 support. > > No functional changes. > > Signed-off-by: Jamin Lin > --- > hw/arm/aspeed_ast10x0.c | 128 ++++++++++++++++++++++------------------ > 1 file changed, 70 insertions(+), 58 deletions(-) LGTM, Reviewed-by: Cédric Le Goater Thanks, C.