From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo08F-0002hO-NT for qemu-devel@nongnu.org; Fri, 10 Aug 2018 01:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo08E-0000qO-Ql for qemu-devel@nongnu.org; Fri, 10 Aug 2018 01:38:39 -0400 References: <20180809204010.3579-1-hpoussin@reactos.org> <20180809204010.3579-2-hpoussin@reactos.org> <20180810010439.GC4079@umbus> From: =?UTF-8?Q?Herv=c3=a9_Poussineau?= Message-ID: <2cb987ea-9d45-ced2-83d5-eadc7821d41b@reactos.org> Date: Fri, 10 Aug 2018 07:38:32 +0200 MIME-Version: 1.0 In-Reply-To: <20180810010439.GC4079@umbus> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] hw/ppc: on 40p machine, change default firmware to OpenBIOS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, Mark Cave-Ayland , Alexander Graf , qemu-ppc@nongnu.org Le 10/08/2018 à 03:04, David Gibson a écrit : > On Thu, Aug 09, 2018 at 10:40:09PM +0200, Hervé Poussineau wrote: >> OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff >> Use it, instead of relying on the presence of a proprietary >> firmware. > > Uh.. openhackware might be, well, a hack, but I don't think it's > propietary. Replacing it with openbios might well be a good idea, but > we want an accurrate reason for doing so. Oops, you're right. That's what happens when you try to change/expand your commit messages just before sending the patch. I will resend. > >> Signed-off-by: Hervé Poussineau >> --- >> hw/ppc/prep.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c >> index 3401570d98..1558855247 100644 >> --- a/hw/ppc/prep.c >> +++ b/hw/ppc/prep.c >> @@ -736,7 +736,7 @@ static void ibm_40p_init(MachineState *machine) >> /* PCI host */ >> dev = qdev_create(NULL, "raven-pcihost"); >> if (!bios_name) { >> - bios_name = BIOS_FILENAME; >> + bios_name = "openbios-ppc"; >> } >> qdev_prop_set_string(dev, "bios-name", bios_name); >> qdev_prop_set_uint32(dev, "elf-machine", PPC_ELF_MACHINE); >