From: Paolo Bonzini <pbonzini@redhat.com>
To: "Brian Norris" <briannorris@chromium.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Joe Slater <joe.slater@windriver.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"MacLeod, Randy" <randy.macleod@windriver.com>
Subject: Re: [PATCH 1/1] os_find_datadir: search as in version 4.2
Date: Sat, 23 Jan 2021 19:08:59 +0100 [thread overview]
Message-ID: <2cb98ec4-9805-8474-9612-acbdf18c29ac@redhat.com> (raw)
In-Reply-To: <CA+ASDXOSR5ueNpwKRzuEEu9emS=yfkaLZiPt8Va_ZNx5vLRbgg@mail.gmail.com>
On 23/01/21 03:05, Brian Norris wrote:
> It turns out that Paolo inadvertently (?) fixed this issue by
> refactoring, in v5.2.0:
> ea1edcd7da1a vl: relocate paths to data directories
> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ea1edcd7da1a375ef7ccf8aa93b72827b518ad8e;hp=63c4db4c2e6d221cecb5aafa365934bb05724cb4
That wasn't entirely inadvertent. It had been on my todo list to fix
relocatability for good, I just didn't remember how it got on the list. :)
So on one hand I didn't remember it to be a regression, and I only
really set out to make QEMU relocatable in order to enable the change of
commit d17f305a26 ("configure: use a platform-neutral prefix",
2020-09-30). On the other hand, your report was what had made me aware
that relocatable installs were buggy and inconsistent.
Paolo
next prev parent reply other threads:[~2021-01-23 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 22:58 [PATCH 1/1] os_find_datadir: search as in version 4.2 Joe Slater
2020-06-16 9:19 ` Peter Maydell
2020-06-16 15:37 ` Slater, Joseph
2020-07-15 19:37 ` Peter Maydell
2020-07-15 19:57 ` Marc-André Lureau
2020-08-08 1:35 ` Brian Norris
2020-08-08 15:34 ` Peter Maydell
2020-08-10 7:29 ` Marc-André Lureau
2020-08-10 21:41 ` Brian Norris
2021-01-23 2:05 ` Brian Norris
2021-01-23 18:08 ` Paolo Bonzini [this message]
2020-07-16 14:12 ` Marc-André Lureau
2020-08-10 7:33 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb98ec4-9805-8474-9612-acbdf18c29ac@redhat.com \
--to=pbonzini@redhat.com \
--cc=briannorris@chromium.org \
--cc=joe.slater@windriver.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).