From: David Hildenbrand <david@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>
Subject: Re: [PATCH fixup] s390x: fixup for "s390x/cpumodel: add 3931 and 3932"
Date: Thu, 1 Jul 2021 10:48:00 +0200 [thread overview]
Message-ID: <2cc2bf2a-d1cd-d79a-318a-baf03e123045@redhat.com> (raw)
In-Reply-To: <20210701084348.26556-1-borntraeger@de.ibm.com>
On 01.07.21 10:43, Christian Borntraeger wrote:
> as discussed we want to change some facility names. Please merge
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> target/s390x/cpu_features_def.h.inc | 4 ++--
> target/s390x/gen-features.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/s390x/cpu_features_def.h.inc b/target/s390x/cpu_features_def.h.inc
> index 6f92b155c3b1..33c67e36cf79 100644
> --- a/target/s390x/cpu_features_def.h.inc
> +++ b/target/s390x/cpu_features_def.h.inc
> @@ -111,9 +111,9 @@ DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
> DEF_FEAT(UNPACK, "unpack", STFL, 161, "Unpack facility")
> DEF_FEAT(NNPA, "nnpa", STFL, 165, "NNPA facility")
> DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH2, "vxpdeh2", STFL, 192, "Vector-Packed-Decimal-Enhancement facility 2")
> -DEF_FEAT(BEAR, "bear", STFL, 193, "BEAR-enhancement facility ")
> +DEF_FEAT(BEAR_ENH, "beareh", STFL, 193, "BEAR-enhancement facility ")
> DEF_FEAT(RDP, "rdp", STFL, 194, "Reset-DAT-protection facility ")
> -DEF_FEAT(ACTIVITY, "activity", STFL, 196, "Processor-Activity-Instrumentation facility ")
> +DEF_FEAT(PAI, "pai", STFL, 196, "Processor-Activity-Instrumentation facility ")
>
> /* Features exposed via SCLP SCCB Byte 80 - 98 (bit numbers relative to byte-80) */
> DEF_FEAT(SIE_GSLS, "gsls", SCLP_CONF_CHAR, 40, "SIE: Guest-storage-limit-suppression facility")
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index a7396d3d5f30..7d85322d6814 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -572,9 +572,9 @@ static uint16_t full_GEN15_GA1[] = {
> static uint16_t full_GEN16_GA1[] = {
> S390_FEAT_NNPA,
> S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2,
> - S390_FEAT_BEAR,
> + S390_FEAT_BEAR_ENH,
> S390_FEAT_RDP,
> - S390_FEAT_ACTIVITY,
> + S390_FEAT_PAI,
> };
>
>
>
For the final patch
Reviewed-by: David Hildenbrand <david@redhat.com>
thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-07-01 8:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 20:19 [PATCH 0/1] Add features and cpu models Christian Borntraeger
2021-06-22 20:19 ` [PATCH 1/1] s390x/cpumodel: add 3931 and 3932 Christian Borntraeger
2021-06-30 13:32 ` David Hildenbrand
2021-06-30 13:53 ` Christian Borntraeger
2021-06-30 15:32 ` Cornelia Huck
2021-06-30 15:56 ` Christian Borntraeger
2021-07-01 7:45 ` David Hildenbrand
2021-07-01 8:42 ` Thomas Huth
2021-06-22 20:28 ` [PATCH 0/1] Add features and cpu models no-reply
2021-06-25 9:55 ` Cornelia Huck
2021-07-01 8:43 ` [PATCH fixup] s390x: fixup for "s390x/cpumodel: add 3931 and 3932" Christian Borntraeger
2021-07-01 8:48 ` David Hildenbrand [this message]
2021-07-01 11:47 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cc2bf2a-d1cd-d79a-318a-baf03e123045@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).