From: Paolo Bonzini <pbonzini@redhat.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>,
Jianjun Duan <duanj@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org, mst@redhat.com,
quintela@redhat.com, mark.cave-ayland@ilande.co.uk,
mdroth@linux.vnet.ibm.com, mreitz@redhat.com,
blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org,
kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com,
rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ
Date: Mon, 6 Jun 2016 15:47:28 +0200 [thread overview]
Message-ID: <2cd6336c-be92-acb7-6e26-a345c38c9bc7@redhat.com> (raw)
In-Reply-To: <877fe7iqj3.fsf@oc4731375738.ibm.com>
On 02/06/2016 17:01, Sascha Silbe wrote:
>> > + /* For fields which need customized handling, such as QTAILQ in queue.h*/
>> > + VMS_CSTM = 0x8000,
> Can you describe (in the comment) how this customised handling is
> performed, please? I.e. describe what exactly happens if the flag is
> set, from the point of view of an API consumer.
>
> Also, why do you need this flag at all? The only change I can see is
> that you pass additional information to VMStateInfo.get() / .put(),
> using NULL if it's not set. Why don't you just always pass the
> additional information? If the additional information is not needed by
> get() / put() the parameter will be unused anyway.
Having the flag seemed like a good idea to me, because it gives a
specific meaning to the offset fields in the VMStateField. On the other
hand, it's true that it's unused...
Paolo
next prev parent reply other threads:[~2016-06-06 13:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 18:02 [Qemu-devel] [QEMU RFC PATCH v3 0/6]Migration: ensure hotplug and migration work together Jianjun Duan
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 1/6] Migration: Defined VMStateDescription struct for spapr_drc Jianjun Duan
2016-06-02 4:07 ` David Gibson
2016-06-03 0:28 ` Jianjun Duan
2016-06-03 1:48 ` David Gibson
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 2/6] vmstate: Define VARRAY with VMS_ALLOC Jianjun Duan
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 3/6] Migration: extend VMStateInfo Jianjun Duan
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ Jianjun Duan
2016-05-31 19:54 ` Paolo Bonzini
2016-05-31 21:53 ` Jianjun Duan
2016-06-01 15:29 ` Paolo Bonzini
2016-06-01 17:06 ` Jianjun Duan
2016-06-01 18:32 ` Paolo Bonzini
2016-06-02 3:58 ` David Gibson
2016-06-02 15:01 ` Sascha Silbe
2016-06-02 16:11 ` Jianjun Duan
2016-06-07 14:43 ` Dr. David Alan Gilbert
2016-06-07 16:31 ` Paolo Bonzini
2016-06-07 16:33 ` Michael S. Tsirkin
2016-06-07 16:34 ` Dr. David Alan Gilbert
2016-06-07 16:35 ` Paolo Bonzini
2016-06-07 16:46 ` Dr. David Alan Gilbert
2016-06-07 16:43 ` [Qemu-devel] [Qemu-ppc] " Jianjun Duan
2016-06-03 17:12 ` [Qemu-devel] " Jianjun Duan
2016-06-06 13:47 ` Paolo Bonzini [this message]
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 5/6] Migration: migrate ccs_list in spapr state Jianjun Duan
2016-05-31 18:02 ` [Qemu-devel] [QEMU RFC PATCH v3 6/6] Migration: migrate pending_events of " Jianjun Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd6336c-be92-acb7-6e26-a345c38c9bc7@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dmitry@daynix.com \
--cc=duanj@linux.vnet.ibm.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=silbe@linux.vnet.ibm.com \
--cc=veroniabahaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).