From: Richard Henderson <richard.henderson@linaro.org>
To: Mikhail Tyutin <m.tyutin@yadro.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, alex.bennee@linaro.org,
Aleksandr Anenkov <a.anenkov@yadro.com>
Subject: Re: [PATCH] Add support of callbacks after instructions to plugin api
Date: Tue, 8 Aug 2023 07:47:15 -0700 [thread overview]
Message-ID: <2cdaf4c5-2151-0acf-8bc9-55ab719e874f@linaro.org> (raw)
In-Reply-To: <20230808134435.2719-1-m.tyutin@yadro.com>
On 8/8/23 06:44, Mikhail Tyutin wrote:
> Initially, we can only call the callback BEFORE instructions. This commit adds the ability to insert the callback AFTER instructions.
>
> No callback call for control-flow instructions.
You're going to miss whole categories of instructions, not just control-flow. You're
going to miss anything that raises an exception. The list goes on and on. This is why we
didn't implement this "after" hook in the first place.
r~
next prev parent reply other threads:[~2023-08-08 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 13:44 [PATCH] Add support of callbacks after instructions to plugin api Mikhail Tyutin
2023-08-08 14:47 ` Richard Henderson [this message]
2023-08-08 15:48 ` Mikhail Tyutin
2023-08-08 15:15 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cdaf4c5-2151-0acf-8bc9-55ab719e874f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=a.anenkov@yadro.com \
--cc=alex.bennee@linaro.org \
--cc=m.tyutin@yadro.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).