qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Frediano Ziglio <fziglio@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: Remove unused include
Date: Tue, 8 Jan 2019 16:58:27 +0100	[thread overview]
Message-ID: <2ce5aafa-a486-9f3a-20b7-2842094132e0@redhat.com> (raw)
In-Reply-To: <20190107184404.31993-1-fziglio@redhat.com>

On 1/7/19 7:44 PM, Frediano Ziglio wrote:
> The definitions in the header are not  used.

Indeed, since e16f4c8770b.

> Also this fixes porting SPICE to Windows where the header is not
> available.
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

(I might resend your patch in another series of mine)

> ---
>  ui/spice-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 525e0929b9..fb87944a24 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -18,7 +18,6 @@
>  #include "qemu/osdep.h"
>  #include <spice.h>
>  
> -#include <netdb.h>
>  #include "sysemu/sysemu.h"
>  
>  #include "ui/qemu-spice.h"
> 

  reply	other threads:[~2019-01-08 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 18:44 [Qemu-devel] [PATCH] spice: Remove unused include Frediano Ziglio
2019-01-08 15:58 ` Philippe Mathieu-Daudé [this message]
2019-01-10  7:56 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ce5aafa-a486-9f3a-20b7-2842094132e0@redhat.com \
    --to=philmd@redhat.com \
    --cc=fziglio@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).