From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Thoughts on CONFIG_TOOLS & CONFIG_USER_ONLY
Date: Fri, 31 Dec 2021 12:20:16 +0100 [thread overview]
Message-ID: <2ce6f1cb-5fb0-5515-4040-3367d98d1919@redhat.com> (raw)
Hi,
The CONFIG_USER_ONLY definition allows limiting user-mode
code to user emulation (in contrast to system emulation).
We often use it in common code.
Often the negative form (to *exclude* user-mode) is used.
This works fine with system emulation in mind, but it could
introduce subtle bugs when neither user nor system emulation
are used, for example with tools.
There is a CONFIG_TOOLS definition, but it is not used in C:
config-host.mak:CONFIG_TOOLS=y
config-host.h:#define CONFIG_TOOLS 1
Not sure how to clarify / improve, this is a bit confusing.
Just thinking loudly :)
Regards,
Phil.
reply other threads:[~2021-12-31 11:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce6f1cb-5fb0-5515-4040-3367d98d1919@redhat.com \
--to=philmd@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).