From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Miaoqian Lin <linmq006@gmail.com>, Qiushi Wu <wu000273@umn.edu>
Cc: Gabriel Somlo <somlo@cmu.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
Date: Tue, 16 Nov 2021 16:28:34 +0100 [thread overview]
Message-ID: <2ced2fae-2ffd-3a70-f02c-175662baf7bc@redhat.com> (raw)
In-Reply-To: <20211116114233.29462-1-linmq006@gmail.com>
On 11/16/21 12:42, Miaoqian Lin wrote:
> When kobject_init_and_add() fails, entry should be freed just like
> when sysfs_create_bin_file() fails.
>
Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/firmware/qemu_fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 172c751a4f6c..0f404777f016 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
> fw_cfg_sel_ko, "%d", entry->select);
> if (err) {
> kobject_put(&entry->kobj);
> + kfree(entry);
> return err;
> }
>
>
next prev parent reply other threads:[~2021-11-16 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 11:42 [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file Miaoqian Lin
2021-11-16 15:28 ` Philippe Mathieu-Daudé [this message]
2021-11-30 17:18 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ced2fae-2ffd-3a70-f02c-175662baf7bc@redhat.com \
--to=philmd@redhat.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).