From: Hanna Reitz <hreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org,
nsoffer@redhat.com, nikita.lapshin@virtuozzo.com, den@openvz.org,
jsnow@redhat.com
Subject: Re: [PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat
Date: Tue, 2 Nov 2021 13:48:06 +0100 [thread overview]
Message-ID: <2cfa2b7d-feaf-b9c3-db61-2bbe49a84fe0@redhat.com> (raw)
In-Reply-To: <20211028102441.1878668-3-vsementsov@virtuozzo.com>
On 28.10.21 12:24, Vladimir Sementsov-Ogievskiy wrote:
> Let's detect block-size automatically if not specified by user:
>
> If both files define cluster-size, use minimum to be more precise.
> If both files don't specify cluster-size, use default of 64K
> If only one file specify cluster-size, just use it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> docs/tools/qemu-img.rst | 7 +++-
> qemu-img.c | 71 +++++++++++++++++++++++++++++++++++++----
> qemu-img-cmds.hx | 4 +--
> 3 files changed, 72 insertions(+), 10 deletions(-)
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
next prev parent reply other threads:[~2021-11-02 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 10:24 [PATCH v3 0/4] qemu-img compare --stat Vladimir Sementsov-Ogievskiy
2021-10-28 10:24 ` [PATCH v3 1/4] qemu-img: implement " Vladimir Sementsov-Ogievskiy
2021-10-29 20:25 ` Eric Blake
2021-11-02 12:40 ` Hanna Reitz
2021-10-28 10:24 ` [PATCH v3 2/4] qemu-img: make --block-size optional for " Vladimir Sementsov-Ogievskiy
2021-10-29 20:32 ` Eric Blake
2021-11-01 8:03 ` Vladimir Sementsov-Ogievskiy
2021-11-01 14:19 ` Eric Blake
2021-11-02 12:48 ` Hanna Reitz [this message]
2021-10-28 10:24 ` [PATCH v3 3/4] qemu-img: add --shallow option for qemu-img compare Vladimir Sementsov-Ogievskiy
2021-10-29 20:44 ` Eric Blake
2021-11-01 8:22 ` Vladimir Sementsov-Ogievskiy
2021-10-28 10:24 ` [PATCH v3 4/4] iotests: add qemu-img-compare-stat test Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cfa2b7d-feaf-b9c3-db61-2bbe49a84fe0@redhat.com \
--to=hreitz@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=nikita.lapshin@virtuozzo.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).