From: Laurent Vivier <laurent@vivier.eu>
To: Paolo Bonzini <pbonzini@redhat.com>,
Patrick Venture <venture@google.com>,
philmd@redhat.com
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/nvram: use at24 macro
Date: Mon, 21 Feb 2022 18:23:15 +0100 [thread overview]
Message-ID: <2cff027b-408d-5d9f-acb8-320242f77bd7@vivier.eu> (raw)
In-Reply-To: <b043c11d-a007-6579-180f-4dd8f0bcae5d@redhat.com>
Le 25/01/2022 à 10:20, Paolo Bonzini a écrit :
> On 1/19/22 22:43, Patrick Venture wrote:
>> Use the macro for going from I2CSlave to EEPROMState.
>>
>> Signed-off-by: Patrick Venture <venture@google.com>
>> ---
>> hw/nvram/eeprom_at24c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
>> index af6f5dbb99..da435500ba 100644
>> --- a/hw/nvram/eeprom_at24c.c
>> +++ b/hw/nvram/eeprom_at24c.c
>> @@ -54,7 +54,7 @@ struct EEPROMState {
>> static
>> int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
>> {
>> - EEPROMState *ee = container_of(s, EEPROMState, parent_obj);
>> + EEPROMState *ee = AT24C_EE(s);
>> switch (event) {
>> case I2C_START_SEND:
>
> Cc: qemu-trivial@nongnu.org
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2022-02-21 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 21:43 [PATCH] hw/nvram: use at24 macro Patrick Venture
2022-01-19 22:48 ` Philippe Mathieu-Daudé via
2022-01-24 19:46 ` Patrick Venture
2022-01-25 9:20 ` Paolo Bonzini
2022-02-21 17:23 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cff027b-408d-5d9f-acb8-320242f77bd7@vivier.eu \
--to=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).