From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] hmp-commands.hx: List abbreviation after command for cont, quit, print
Date: Sat, 21 Nov 2020 17:05:40 +0100 [thread overview]
Message-ID: <2d016c8b-aa2b-6416-ab39-dc7517a02010@redhat.com> (raw)
In-Reply-To: <20201121151711.20783-1-peter.maydell@linaro.org>
On 11/21/20 4:17 PM, Peter Maydell wrote:
> We have four HMP commands which have a single-character abbreviated
> version: cont ('c'), quit ('q'), print ('p') and help ('h'). For
> cont, quit and print, we list the abbreviation first in the help
> documentation and the command name. This has the odd effect that in
> the full 'help' command list these commands end up sorted out of
> alphabetical order (they end up after all the other commands that
> start with the same letter). As it happens, the only place this
> currently changes the order is for 'cont'.
>
> Abbreviation first is also not a very logical order, and it doesn't
> match what we use for 'help' (which is 'help|?'). Put the full
> command name first in both the help text and the .name field for
> cont, quit and print.
>
> Fixes: https://bugs.launchpad.net/qemu/+bug/1614609
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hmp-commands.hx | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-11-21 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 15:17 [PATCH] hmp-commands.hx: List abbreviation after command for cont, quit, print Peter Maydell
2020-11-21 16:05 ` Philippe Mathieu-Daudé [this message]
2020-12-01 10:29 ` Dr. David Alan Gilbert
2020-12-08 18:05 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d016c8b-aa2b-6416-ab39-dc7517a02010@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).