From: Thomas Huth <thuth@redhat.com>
To: "Igor Mammedov" <imammedo@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Andrew Jones <drjones@redhat.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model()
Date: Tue, 5 Sep 2017 07:38:13 +0200 [thread overview]
Message-ID: <2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com> (raw)
In-Reply-To: <20170904210649.1266364c@Igors-MacBook-Pro.local>
On 04.09.2017 21:06, Igor Mammedov wrote:
> On Mon, 4 Sep 2017 12:03:09 -0300
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
>> Hi Igor,
>>
>> On 09/04/2017 11:00 AM, Igor Mammedov wrote:
>>> function not just parses features but also converts CPU model
>>> name to CPU type, rename it to reflect what it actualy does.
>>
>> Why not squash this with your 1st patch "split cpu_generic_init()"?
> there I went with current/exiting way to call that part of code,
> and here I'm renaming it to show what it does exactly.
>
> But I don't have any preference here, so I can squash this patch
> into 1/6 on respin, if you prefer.
+1 for squashing
Thomas
next prev parent reply other threads:[~2017-09-05 5:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 14:00 [Qemu-devel] [PATCH 0/6] generalize parsing of cpu_model (x86/arm) Igor Mammedov
2017-09-04 14:00 ` [Qemu-devel] [PATCH 1/6] qom: cpus: split cpu_generic_init() on feature parsing and cpu creation parts Igor Mammedov
2017-09-04 15:30 ` Philippe Mathieu-Daudé
2017-09-04 14:00 ` [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error Igor Mammedov
2017-09-04 15:15 ` Philippe Mathieu-Daudé
2017-09-11 14:30 ` Igor Mammedov
2017-09-05 5:41 ` Thomas Huth
2017-09-05 11:22 ` Eduardo Habkost
2017-09-11 14:51 ` Igor Mammedov
2017-09-05 20:19 ` Eduardo Habkost
2017-09-11 14:23 ` Igor Mammedov
2017-09-04 14:00 ` [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model() Igor Mammedov
2017-09-04 15:03 ` Philippe Mathieu-Daudé
2017-09-04 19:06 ` Igor Mammedov
2017-09-05 5:38 ` Thomas Huth [this message]
2017-09-11 15:07 ` Igor Mammedov
2017-09-04 14:01 ` [Qemu-devel] [PATCH 4/6] vl.c: convert cpu_model to cpu type and set of global properties before machine_init() Igor Mammedov
2017-09-04 14:01 ` [Qemu-devel] [PATCH 5/6] pc: use generic cpu_model parsing Igor Mammedov
2017-09-04 15:33 ` Philippe Mathieu-Daudé
2017-09-04 14:01 ` [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly Igor Mammedov
2017-09-05 21:31 ` Eduardo Habkost
2017-09-05 21:47 ` Alistair Francis
2017-09-05 22:12 ` Eduardo Habkost
2017-09-05 22:46 ` Alistair Francis
2017-09-06 0:16 ` Alistair Francis
2017-09-09 20:30 ` Eduardo Habkost
2017-09-09 22:41 ` Peter Maydell
2017-09-09 23:22 ` Eduardo Habkost
2017-09-12 10:22 ` Igor Mammedov
2017-09-12 12:01 ` Eduardo Habkost
2017-09-12 10:53 ` Igor Mammedov
2017-09-12 16:29 ` Alistair Francis
2017-09-12 11:02 ` Igor Mammedov
2017-09-12 12:04 ` Eduardo Habkost
2017-09-12 12:11 ` Igor Mammedov
2017-09-12 12:53 ` Eduardo Habkost
2017-09-12 14:06 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).