Re: [PATCH 2/4] hw/arm/mps2-tz.c: Add extra data parameter to MakeDevFn

[Richard Henderson <richard.henderson@linaro.org>]

On 9/3/21 5:14 PM, Peter Maydell wrote:
> The mps2-tz boards use a data-driven structure to create the devices
> that sit behind peripheral protection controllers.  Currently the
> functions which create these devices are passed an 'opaque' pointer
> which is always the address within the machine struct of the device
> to create, and some "all devices need this" information like irqs and
> addresses.
> 
> If a specific device needs more information than this, it is
> currently not possible to pass that through from the PPCInfo
> data structure. Add support for passing an extra data parameter,
> so that we can more flexibly handle the needs of specific
> device types. To provide some type-safety we make this extra
> parameter a pointer to a union (which initially has no members).
> 
> In particular, we would like to be able to indicate which of the
> i2c controllers are for on-board devices only and which are
> connected to the external 'shield' expansion port; a subsequent
> patch will use this mechanism for that purpose.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/arm/mps2-tz.c | 35 ++++++++++++++++++++++-------------
>   1 file changed, 22 insertions(+), 13 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~