* [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on
@ 2021-02-28 5:06 Bin Meng
2021-02-28 16:08 ` Philippe Mathieu-Daudé
2021-03-22 14:23 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Bin Meng @ 2021-02-28 5:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-block, qemu-devel; +Cc: Bin Meng
From: Bin Meng <bin.meng@windriver.com>
"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_SD is on.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
hw/sd/sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 8b397effbc..7b09ce9c2e 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -47,6 +47,7 @@
#include "qemu/timer.h"
#include "qemu/log.h"
#include "qemu/module.h"
+#include "qemu-common.h"
#include "sdmmc-internal.h"
#include "trace.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on
2021-02-28 5:06 [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on Bin Meng
@ 2021-02-28 16:08 ` Philippe Mathieu-Daudé
2021-03-22 14:23 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-28 16:08 UTC (permalink / raw)
To: Bin Meng, qemu-block, qemu-devel; +Cc: Bin Meng
On 2/28/21 6:06 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_SD is on.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on
2021-02-28 5:06 [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on Bin Meng
2021-02-28 16:08 ` Philippe Mathieu-Daudé
@ 2021-03-22 14:23 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-22 14:23 UTC (permalink / raw)
To: Bin Meng, qemu-block, qemu-devel; +Cc: Bin Meng
On 2/28/21 6:06 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_SD is on.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> hw/sd/sd.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, patch applied to sdmmc-fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-22 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-28 5:06 [PATCH] hw/sd: sd: Fix build error when DEBUG_SD is on Bin Meng
2021-02-28 16:08 ` Philippe Mathieu-Daudé
2021-03-22 14:23 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).