* [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder
@ 2017-07-11 9:31 Thomas Huth
2017-07-11 9:35 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Thomas Huth @ 2017-07-11 9:31 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini, Peter Crosthwaite, Richard Henderson
Cc: qemu-trivial, Philippe Mathieu-Daudé
The header is only used by accel/tcg/cputlb.c so we can
move it to the accel/tcg/ folder, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Note: This patch should be applied after Philippe's "MAINTAINERS:
update TCG entries" patch here:
https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html
MAINTAINERS | 1 -
softmmu_template.h => accel/tcg/softmmu_template.h | 0
2 files changed, 1 deletion(-)
rename softmmu_template.h => accel/tcg/softmmu_template.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 74b3956..993b12e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net>
S: Maintained
F: cpus.c
F: exec.c
-F: softmmu_template.h
F: accel/tcg/
F: include/exec/cpu*.h
F: include/exec/exec-all.h
diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h
similarity index 100%
rename from softmmu_template.h
rename to accel/tcg/softmmu_template.h
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder
2017-07-11 9:31 [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder Thomas Huth
@ 2017-07-11 9:35 ` Laurent Vivier
2017-07-11 11:23 ` [Qemu-devel] " Paolo Bonzini
2017-07-11 18:55 ` [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/ Philippe Mathieu-Daudé
2 siblings, 0 replies; 9+ messages in thread
From: Laurent Vivier @ 2017-07-11 9:35 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini, Peter Crosthwaite,
Richard Henderson
Cc: qemu-trivial, Philippe Mathieu-Daudé
On 11/07/2017 11:31, Thomas Huth wrote:
> The header is only used by accel/tcg/cputlb.c so we can
> move it to the accel/tcg/ folder, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Note: This patch should be applied after Philippe's "MAINTAINERS:
> update TCG entries" patch here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html
>
> MAINTAINERS | 1 -
> softmmu_template.h => accel/tcg/softmmu_template.h | 0
> 2 files changed, 1 deletion(-)
> rename softmmu_template.h => accel/tcg/softmmu_template.h (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 74b3956..993b12e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net>
> S: Maintained
> F: cpus.c
> F: exec.c
> -F: softmmu_template.h
> F: accel/tcg/
> F: include/exec/cpu*.h
> F: include/exec/exec-all.h
> diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h
> similarity index 100%
> rename from softmmu_template.h
> rename to accel/tcg/softmmu_template.h
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder
2017-07-11 9:31 [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder Thomas Huth
2017-07-11 9:35 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2017-07-11 11:23 ` Paolo Bonzini
2017-07-11 18:55 ` [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/ Philippe Mathieu-Daudé
2 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2017-07-11 11:23 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Peter Crosthwaite, Richard Henderson
Cc: qemu-trivial, Philippe Mathieu-Daudé
On 11/07/2017 11:31, Thomas Huth wrote:
> The header is only used by accel/tcg/cputlb.c so we can
> move it to the accel/tcg/ folder, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Note: This patch should be applied after Philippe's "MAINTAINERS:
> update TCG entries" patch here:
> https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html
>
> MAINTAINERS | 1 -
> softmmu_template.h => accel/tcg/softmmu_template.h | 0
> 2 files changed, 1 deletion(-)
> rename softmmu_template.h => accel/tcg/softmmu_template.h (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 74b3956..993b12e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net>
> S: Maintained
> F: cpus.c
> F: exec.c
> -F: softmmu_template.h
> F: accel/tcg/
> F: include/exec/cpu*.h
> F: include/exec/exec-all.h
> diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h
> similarity index 100%
> rename from softmmu_template.h
> rename to accel/tcg/softmmu_template.h
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-07-11 9:31 [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder Thomas Huth
2017-07-11 9:35 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-07-11 11:23 ` [Qemu-devel] " Paolo Bonzini
@ 2017-07-11 18:55 ` Philippe Mathieu-Daudé
2017-07-12 5:52 ` Thomas Huth
2 siblings, 1 reply; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-07-11 18:55 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Paolo Bonzini, Peter Crosthwaite,
Richard Henderson, Thomas Huth
Cc: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
same as Thomas previous patch. this file had no entry in MAINTAINERS.
atomic_template.h => accel/tcg/atomic_template.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename atomic_template.h => accel/tcg/atomic_template.h (100%)
diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
similarity index 100%
rename from atomic_template.h
rename to accel/tcg/atomic_template.h
--
2.13.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-07-11 18:55 ` [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/ Philippe Mathieu-Daudé
@ 2017-07-12 5:52 ` Thomas Huth
2017-07-13 11:35 ` Paolo Bonzini
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2017-07-12 5:52 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Alex Bennée,
Paolo Bonzini, Peter Crosthwaite, Richard Henderson
On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> same as Thomas previous patch. this file had no entry in MAINTAINERS.
>
> atomic_template.h => accel/tcg/atomic_template.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename atomic_template.h => accel/tcg/atomic_template.h (100%)
>
> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
> similarity index 100%
> rename from atomic_template.h
> rename to accel/tcg/atomic_template.h
It's also used by a file in tcg/, but I've checked, and yes, the code
still compiles fine if the header gets moved to accel/tcg/.
Tested-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-07-12 5:52 ` Thomas Huth
@ 2017-07-13 11:35 ` Paolo Bonzini
2017-09-07 9:30 ` Thomas Huth
0 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2017-07-13 11:35 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel,
Alex Bennée, Peter Crosthwaite, Richard Henderson
On 12/07/2017 07:52, Thomas Huth wrote:
> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> same as Thomas previous patch. this file had no entry in MAINTAINERS.
>>
>> atomic_template.h => accel/tcg/atomic_template.h | 0
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>> rename atomic_template.h => accel/tcg/atomic_template.h (100%)
>>
>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
>> similarity index 100%
>> rename from atomic_template.h
>> rename to accel/tcg/atomic_template.h
>
> It's also used by a file in tcg/, but I've checked, and yes, the code
> still compiles fine if the header gets moved to accel/tcg/.
>
> Tested-by: Thomas Huth <thuth@redhat.com>
>
That part of tcg/tcg-runtime.c probably should be moved to user-exec.c,
and user-exec.c should in turn be in accel/tcg.
Since this is just code movement we can do it after soft freeze.
Philippe, can you send v2?
Thanks,
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-07-13 11:35 ` Paolo Bonzini
@ 2017-09-07 9:30 ` Thomas Huth
2017-09-11 10:26 ` Paolo Bonzini
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2017-09-07 9:30 UTC (permalink / raw)
To: Paolo Bonzini, Philippe Mathieu-Daudé, qemu-devel,
Alex Bennée, Peter Crosthwaite, Richard Henderson
On 13.07.2017 13:35, Paolo Bonzini wrote:
> On 12/07/2017 07:52, Thomas Huth wrote:
>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote:
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> same as Thomas previous patch. this file had no entry in MAINTAINERS.
>>>
>>> atomic_template.h => accel/tcg/atomic_template.h | 0
>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%)
>>>
>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
>>> similarity index 100%
>>> rename from atomic_template.h
>>> rename to accel/tcg/atomic_template.h
>>
>> It's also used by a file in tcg/, but I've checked, and yes, the code
>> still compiles fine if the header gets moved to accel/tcg/.
>>
>> Tested-by: Thomas Huth <thuth@redhat.com>
>>
>
> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c,
> and user-exec.c should in turn be in accel/tcg.
>
> Since this is just code movement we can do it after soft freeze.
> Philippe, can you send v2?
Ping?
Looks like the atomic_template.h is still in the main directory ...
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-09-07 9:30 ` Thomas Huth
@ 2017-09-11 10:26 ` Paolo Bonzini
2017-09-11 14:04 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2017-09-11 10:26 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel,
Alex Bennée, Peter Crosthwaite, Richard Henderson
On 07/09/2017 11:30, Thomas Huth wrote:
> On 13.07.2017 13:35, Paolo Bonzini wrote:
>> On 12/07/2017 07:52, Thomas Huth wrote:
>>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote:
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> same as Thomas previous patch. this file had no entry in MAINTAINERS.
>>>>
>>>> atomic_template.h => accel/tcg/atomic_template.h | 0
>>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%)
>>>>
>>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
>>>> similarity index 100%
>>>> rename from atomic_template.h
>>>> rename to accel/tcg/atomic_template.h
>>>
>>> It's also used by a file in tcg/, but I've checked, and yes, the code
>>> still compiles fine if the header gets moved to accel/tcg/.
>>>
>>> Tested-by: Thomas Huth <thuth@redhat.com>
>>>
>>
>> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c,
>> and user-exec.c should in turn be in accel/tcg.
>>
>> Since this is just code movement we can do it after soft freeze.
>> Philippe, can you send v2?
>
> Ping?
>
> Looks like the atomic_template.h is still in the main directory ...
Still waiting for v2...
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/
2017-09-11 10:26 ` Paolo Bonzini
@ 2017-09-11 14:04 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-11 14:04 UTC (permalink / raw)
To: Paolo Bonzini, Thomas Huth, qemu-devel, Alex Bennée,
Peter Crosthwaite, Richard Henderson
>>>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote:
>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>> ---
>>>>> same as Thomas previous patch. this file had no entry in MAINTAINERS.
>>>>>
>>>>> atomic_template.h => accel/tcg/atomic_template.h | 0
>>>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%)
>>>>>
>>>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h
>>>>> similarity index 100%
>>>>> rename from atomic_template.h
>>>>> rename to accel/tcg/atomic_template.h
>>>>
>>>> It's also used by a file in tcg/, but I've checked, and yes, the code
>>>> still compiles fine if the header gets moved to accel/tcg/.
>>>>
>>>> Tested-by: Thomas Huth <thuth@redhat.com>
>>>>
>>>
>>> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c,
>>> and user-exec.c should in turn be in accel/tcg.
>>>
>>> Since this is just code movement we can do it after soft freeze.
>>> Philippe, can you send v2?
>>
>> Ping?
>>
>> Looks like the atomic_template.h is still in the main directory ...
>
> Still waiting for v2...
I chat with Thomas last night about it, with 2.10 freeze I totally
forgot about this, sorry! I'll respin v2 during the day.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-09-11 14:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-11 9:31 [Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder Thomas Huth
2017-07-11 9:35 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-07-11 11:23 ` [Qemu-devel] " Paolo Bonzini
2017-07-11 18:55 ` [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/ Philippe Mathieu-Daudé
2017-07-12 5:52 ` Thomas Huth
2017-07-13 11:35 ` Paolo Bonzini
2017-09-07 9:30 ` Thomas Huth
2017-09-11 10:26 ` Paolo Bonzini
2017-09-11 14:04 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).