From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1difpK-0001fz-1A for qemu-devel@nongnu.org; Fri, 18 Aug 2017 07:52:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1difpI-0003f8-Ni for qemu-devel@nongnu.org; Fri, 18 Aug 2017 07:52:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45946) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1difpI-0003dZ-H6 for qemu-devel@nongnu.org; Fri, 18 Aug 2017 07:52:32 -0400 References: <20170818114844.30061-1-cohuck@redhat.com> <20170818114844.30061-4-cohuck@redhat.com> From: Thomas Huth Message-ID: <2d380a07-4298-e1a7-7151-dec1380c8f39@redhat.com> Date: Fri, 18 Aug 2017 13:52:28 +0200 MIME-Version: 1.0 In-Reply-To: <20170818114844.30061-4-cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] s390x: wire up diag288 in tcg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: rth@twiddle.net, agraf@suse.de, borntraeger@de.ibm.com On 18.08.2017 13:48, Cornelia Huck wrote: > Make the diag288 watchdog useable via tcg as well. > > Signed-off-by: Cornelia Huck > --- > target/s390x/misc_helper.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c > index 5a1eba02ab..34d730ba73 100644 > --- a/target/s390x/misc_helper.c > +++ b/target/s390x/misc_helper.c > @@ -103,6 +103,10 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1, uint32_t r3, uint32_t num) > handle_diag_308(env, r1, r3); > r = 0; > break; > + case 0x288: > + /* time bomb (watchdog) */ > + r = handle_diag_288(env, r1, r3); > + break; > default: > r = -1; > break; Reviewed-by: Thomas Huth