From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3u9y-0001CU-OJ for qemu-devel@nongnu.org; Mon, 07 Nov 2016 19:21:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3u9u-000633-Pm for qemu-devel@nongnu.org; Mon, 07 Nov 2016 19:21:06 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3u9u-00062j-Ig for qemu-devel@nongnu.org; Mon, 07 Nov 2016 19:21:02 -0500 Received: by mail-wm0-x242.google.com with SMTP id c17so19288546wmc.3 for ; Mon, 07 Nov 2016 16:21:02 -0800 (PST) Sender: Paolo Bonzini References: <94eb2c187eda43dba005406c86f7@google.com> From: Paolo Bonzini Message-ID: <2d3a2a2f-c51f-7ae4-8750-081c629c82eb@redhat.com> Date: Tue, 8 Nov 2016 01:20:58 +0100 MIME-Version: 1.0 In-Reply-To: <94eb2c187eda43dba005406c86f7@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Document how x86 gdb_num_core_regs is computed. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Doug Evans , qemu-devel@nongnu.org On 03/11/2016 22:48, Doug Evans wrote: > Hi. > > It helps when reading the code to see how the number is arrived at. > > Signed-off-by: Doug Evans > --- > target-i386/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 14c5186..01f1ab0 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -3721,6 +3721,8 @@ static void x86_cpu_common_class_init(ObjectClass > *oc, void *data) > cc->write_elf32_qemunote = x86_cpu_write_elf32_qemunote; > cc->vmsd = &vmstate_x86_cpu; > #endif > + /* CPU_NB_REGS * 2 = general regs + xmm regs > + 25 = eip, eflags, 6 seg regs, st[0-7], fctrl,...,fop, mxcsr */ > cc->gdb_num_core_regs = CPU_NB_REGS * 2 + 25; > #ifndef CONFIG_USER_ONLY > cc->debug_excp_handler = breakpoint_handler; > -- > > Queued for 2.8, thanks. Paolo