qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: tamiko@43-1.org, arfrever.fta@gmail.com
Subject: Re: [Qemu-devel] [PATCH v4 2/2] Revert commit d4e5ec877ca
Date: Tue, 19 Jun 2018 06:03:14 -0500	[thread overview]
Message-ID: <2d50a447-ac11-f7e1-33e1-a3ffcad5b455@redhat.com> (raw)
In-Reply-To: <20180618175958.29073-3-armbru@redhat.com>

On 06/18/2018 12:59 PM, Markus Armbruster wrote:
> From: Matthias Maier <tamiko@43-1.org>
> 
> This commit removes the PYTHON_UTF8 workaround. The problem with setting
> 
>    LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8
> 
> is that the en_US.UTF-8 locale might not be available. In this case
> setting above locales results in build errors even though another UTF-8
> locale was originally set [1]. The only stable way of fixing the
> encoding problem is by explicitly annotating encoding/decoding in the
> python script.
> 
> [1] https://bugs.gentoo.org/657766
> 
> Signed-off-by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
> Signed-off-by: Matthias Maier <tamiko@43-1.org>
> Message-Id: <20180615220205.6929-3-tamiko@43-1.org>
> ---

Markus, does this need S-o-b from you?  (Then again, if it goes in 
through your tree, that's a moot point, as you'd add it as maintainer)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  parent reply	other threads:[~2018-06-19 11:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 17:59 [Qemu-devel] [PATCH v4 0/2] Fix compilation with python-3 if en_US.UTF-8 is unavailable Markus Armbruster
2018-06-18 17:59 ` [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8' Markus Armbruster
2018-06-18 21:35   ` Eduardo Habkost
2018-06-19  6:28     ` Markus Armbruster
2018-06-19 10:50       ` Eduardo Habkost
2018-06-19 11:52         ` Markus Armbruster
2018-06-19 12:05         ` Daniel P. Berrangé
2018-06-19 13:06           ` Eduardo Habkost
2018-06-19 11:02   ` Eric Blake
2018-06-18 17:59 ` [Qemu-devel] [PATCH v4 2/2] Revert commit d4e5ec877ca Markus Armbruster
2018-06-18 21:35   ` Eduardo Habkost
2018-06-19 11:03   ` Eric Blake [this message]
2018-06-19 11:46     ` Markus Armbruster
2018-06-19 11:59   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d50a447-ac11-f7e1-33e1-a3ffcad5b455@redhat.com \
    --to=eblake@redhat.com \
    --cc=arfrever.fta@gmail.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tamiko@43-1.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).