Re: [RFC PATCH v1 16/25] hw/xen: Rename xen_common.h to xen_native.h

[Paul Durrant <xadimgnik@gmail.com>]

On 02/03/2023 15:34, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> This header is now only for native Xen code, not PV backends that may be
> used in Xen emulation. Since the toolstack libraries may depend on the
> specific version of Xen headers that they pull in (and will set the
> __XEN_TOOLS__ macro to enable internal definitions that they depend on),
> the rule is that xen_native.h (and thus the toolstack library headers)
> must be included *before* any of the headers in include/hw/xen/interface.
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   accel/xen/xen-all.c                           |  1 +
>   hw/9pfs/xen-9p-backend.c                      |  1 +
>   hw/block/dataplane/xen-block.c                |  3 ++-
>   hw/block/xen-block.c                          |  1 -
>   hw/i386/pc_piix.c                             |  4 ++--
>   hw/i386/xen/xen-hvm.c                         | 11 +++++-----
>   hw/i386/xen/xen-mapcache.c                    |  2 +-
>   hw/i386/xen/xen_platform.c                    |  7 +++---
>   hw/xen/trace-events                           |  2 +-
>   hw/xen/xen-operations.c                       |  2 +-
>   hw/xen/xen_pt.c                               |  2 +-
>   hw/xen/xen_pt.h                               |  2 +-
>   hw/xen/xen_pt_config_init.c                   |  2 +-
>   hw/xen/xen_pt_msi.c                           |  4 ++--
>   include/hw/xen/xen.h                          | 22 ++++++++++++-------
>   include/hw/xen/{xen_common.h => xen_native.h} | 10 ++++++---
>   include/hw/xen/xen_pvdev.h                    |  3 ++-
>   17 files changed, 47 insertions(+), 32 deletions(-)
>   rename include/hw/xen/{xen_common.h => xen_native.h} (98%)
> 

Reviewed-by: Paul Durrant <paul@xen.org>