From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCuuv-0007qM-0r for qemu-devel@nongnu.org; Tue, 14 Jun 2016 16:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCuus-0007XC-Up for qemu-devel@nongnu.org; Tue, 14 Jun 2016 16:26:31 -0400 References: <20160612065603.21911-1-famz@redhat.com> <20160614012134.GB26269@ad.usersys.redhat.com> From: John Snow Message-ID: <2d5b128b-2ce6-d8a6-cc07-1210e8463eac@redhat.com> Date: Tue, 14 Jun 2016 16:26:22 -0400 MIME-Version: 1.0 In-Reply-To: <20160614012134.GB26269@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] macio: Use blk_drain instead of blk_drain_all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On 06/13/2016 09:21 PM, Fam Zheng wrote: > On Mon, 06/13 17:33, John Snow wrote: >> >> >> On 06/12/2016 02:56 AM, Fam Zheng wrote: >>> We only care about the associated backend, so blk_drain is more >>> appropriate here. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> hw/ide/macio.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/ide/macio.c b/hw/ide/macio.c >>> index 78c10a0..a8c7321 100644 >>> --- a/hw/ide/macio.c >>> +++ b/hw/ide/macio.c >>> @@ -400,7 +400,7 @@ static void pmac_ide_flush(DBDMA_io *io) >>> IDEState *s = idebus_active_if(&m->bus); >>> >>> if (s->bus->dma->aiocb) { >>> - blk_drain_all(); >>> + blk_drain(s->blk); >>> } >>> } >>> >>> >> >> Reviewed-by: John Snow >> >> Shall I take this through my tree? > > I think that MAINTAINERS says so. :) > > Fam > For now, then: Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js